Skinner

Member
Jul 6, 2017
100
130
I just went through some of the crab battle code to see if I could fix up some of it. I wrote a long post detailing why I decided against it... but it can be confusing and I'd rather not bother with explaining further than this post. To put it all simply.. it's a dumpster fire. There is no fixing it. The author's best bet to fix it is to start from scratch.

So, instead of fixing the code to make it .. make sense .. I've decided to just give all opponent crabs 5 health at the start. I don't like cheating on this, but it's far better than sitting here flipping off my monitor every crab battle ("Why the hell is this crab that is exactly the same as mine, except mine is Epic and the opponent is Rare, hitting me 3x as often as I'm hitting it?") . To install, just put the file in the game folder within your Four Elements Trainer folder (ie: Four Elements Trainer\game\).


If the author IS watching this thread.. two recommendations that would solve a LOT of the issues with the crab battles (and I'm not even going to criticize the fact that 90% of the file is copy/pasted -- which introduced at least 3 bugs that I counted):
- do NOT bias the computer's battler (ie: a crab with 77 ACC should have the same hit chance whether they're NPC or the player's -- in the player's calculation, you multiply by .03 and then .01 .. for the computer you only do .02 .. and that's not all the bias going on there)
- you do not need to do a calculation, then do a (randomized) normalization on that calculation.. then toss it into yet another randomizer. The calculation you do on the ACC alone can be used to get a good hit-chance system going (as long as it's fair across the board -- see previous point) .. no need for all the other junk.
 
Last edited:
Feb 5, 2018
161
55
How to get this ? im stuck after blackmailing asami and got titjob already saw the dream with 2 naga then nothing or is it the end of this version ?
  • New walking around sections Dream/Meditation
  • Continuation of story
  • Various quests/conversations
 

dimrodet

Newbie
Feb 16, 2018
80
61
what's the correct number for ty lee's number game, the walkthrough say answer correctly but no numbers are correct for me
 

tg12345

Newbie
Feb 1, 2019
30
8
I just went through some of the crab battle code to see if I could fix up some of it. I wrote a long post detailing why I decided against it... but it can be confusing and I'd rather not bother with explaining further than this post. To put it all simply.. it's a dumpster fire. There is no fixing it. The author's best bet to fix it is to start from scratch.

So, instead of fixing the code to make it .. make sense .. I've decided to just give all opponent crabs 5 health at the start. I don't like cheating on this, but it's far better than sitting here flipping off my monitor every crab battle ("Why the hell is this crab that is exactly the same as mine, except mine is Epic and the opponent is Rare, hitting me 3x as often as I'm hitting it?") . To install, just put the file in the game folder within your Four Elements Trainer folder (ie: Four Elements Trainer\game\).


If the author IS watching this thread.. two recommendations that would solve a LOT of the issues with the crab battles (and I'm not even going to criticize the fact that 90% of the file is copy/pasted -- which introduced at least 3 bugs that I counted):
- do NOT bias the computer's battler (ie: a crab with 77 ACC should have the same hit chance whether they're NPC or the player's -- in the player's calculation, you multiply by .03 and then .01 .. for the computer you only do .02 .. and that's not all the bias going on there)
- you do not need to do a calculation, then do a (randomized) normalization on that calculation.. then toss it into yet another randomizer. The calculation you do on the ACC alone can be used to get a good hit-chance system going (as long as it's fair across the board -- see previous point) .. no need for all the other junk.
I can't get this to work, I downloaded and pasted into the right folder though :s
 

Skinner

Member
Jul 6, 2017
100
130
I can't get this to work, I downloaded and pasted into the right folder though :s
- When you're looking at the main menu, look at the top left and you'll see a version number. This was made for V0.8.2B - if yours is different, then that could be it. (I downloaded my copy just a few days ago, and the OP hasn't chanced since then so I'd expect mine to be the most up to date version available)
- When you download the file from f95, they give it a filename with random numbers at the start (ie: I just downloaded it and it saved as "363953_bk3_s_arena_shit.rpy"). You need to remove everything up to and including the first underscore (that's the "_" character) -- so for my previous example, I would remove the bold part of the filename I gave (that first underscore is bold.. it just may not look like it). If you downloaded it from the github link in my signature, you don't have to do anything to the filename.
- How many files do you have in your Four Elements Trainer\game folder? If you've only added my mod, you should have: 4 folders, 2 files with a .rpa extension, and 1 file with a .rpy extension. I've attached a screenshot of my game folder, yours should be similar (note: I also did some work on the lake battles, so ignore the bk_l_fightengine.rpy/.rpc files).
- Finally, if the version, filename and directory is correct, open the file in a text editor and scroll down to line 12107. That line and the 4 after it should say: "$ enemy_crab#_hp = 5" (where the # is a number 1-5). If it doesn't then you've got a different file and you need to download and copy/paste it again. If it does have those lines and you're NOT getting an error then there's something else going on somewhere and I wouldn't be able to look into it without having access to the files.

Also note that I don't have any other mods (I'm not exactly sure if there are any other mods for it, to be honest) .. but if you have other mods, they could be conflicting with this.
You don't have permission to view the spoiler content. Log in or register now.
 
Last edited:
  • Like
Reactions: tg12345

Regelious

Member
Aug 17, 2018
255
2,694
I just went through some of the crab battle code to see if I could fix up some of it. I wrote a long post detailing why I decided against it... but it can be confusing and I'd rather not bother with explaining further than this post. To put it all simply.. it's a dumpster fire. There is no fixing it. The author's best bet to fix it is to start from scratch.

So, instead of fixing the code to make it .. make sense .. I've decided to just give all opponent crabs 5 health at the start. I don't like cheating on this, but it's far better than sitting here flipping off my monitor every crab battle ("Why the hell is this crab that is exactly the same as mine, except mine is Epic and the opponent is Rare, hitting me 3x as often as I'm hitting it?") . To install, just put the file in the game folder within your Four Elements Trainer folder (ie: Four Elements Trainer\game\).


If the author IS watching this thread.. two recommendations that would solve a LOT of the issues with the crab battles (and I'm not even going to criticize the fact that 90% of the file is copy/pasted -- which introduced at least 3 bugs that I counted):
- do NOT bias the computer's battler (ie: a crab with 77 ACC should have the same hit chance whether they're NPC or the player's -- in the player's calculation, you multiply by .03 and then .01 .. for the computer you only do .02 .. and that's not all the bias going on there)
- you do not need to do a calculation, then do a (randomized) normalization on that calculation.. then toss it into yet another randomizer. The calculation you do on the ACC alone can be used to get a good hit-chance system going (as long as it's fair across the board -- see previous point) .. no need for all the other junk.
And is this for all the NPC crabs ? Or is it just for the 3rd book or 2nd book Love route ?
 

Skinner

Member
Jul 6, 2017
100
130
And is this for all the NPC crabs ? Or is it just for the 3rd book or 2nd book Love route ?
This has worked on all NPC crabs that I've encountered in book 3 (Iroh's, Shady's during the arena battles, wild crabs). I'm in book 3, and I took the slave route in book 2 (I don't remember picking the route.. I think my cat did it for me while I was in the bathroom or something) .. so these are the only crabs I'm aware of in the game. Can't give any promises because looking into it is spoiling some stuff, but after doing a search for the word "crab", it appears the only area where it might not work is in relation to some ember island. A quick glance says it SHOULD work there too, but again, no promises. If it doesn't when I get to that part (and the battles don't make sense), I'll update it so it's not ridiculous.
 

irreverant

Newbie
Dec 18, 2017
22
35
God this game is the fucking nuts. Your writers went absolutely in on it. The only dissapointment I have is that I've played this game through development. And that I cannot play it all at once when everything is finished. I doubt a sequel would ever be planned, but hell I'd pay for it. You've managed to mix crass humour with intelligent character design, all the while keeping with their themes in the show.

You guys could continue the Avatar series and I'd consider in canon.
 

Laziness

Well-Known Member
Feb 14, 2018
1,486
2,023
It's wild how this porn parody manages to make me feel things above the belt.
And even if I'd balk at the devs making continuations of the story, at least it'd be better than the comics we got. :p
 
4.50 star(s) 268 Votes