Dumb noob question about name inputs

[CarbonBlue]

I am a noob to coding. Went through the ren'py tutorial and I'm starting to build my game, and I'm actually doing ok. However, I'm having some troubles. For each character at their introduction I ask the player if they want to change the character's name with a Yes/No. If they choose yes, I want to add an input for the name. That far I've gotten. Unfortunately it gives me an error.

    scene scene1_2

    "This is Mrs. Kelly. Her default name is Olivia. Would you like to change her name?"

    menu:

        "Yes":
            python:
                olivia_name = renpy.input(_("What is her name?"))

                olivia_name = name.strip() or __("Olivia")


        "No":
            jump olivia_name_done

    label olivia_name_done:

It returns an error that name is not defined. If anyone could help I'd appreciate it.

 

[Winterfire]

define Olivia = Character("[olivia_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])

$olivia_name = renpy.input("What is her name?", "Olivia", None, None, 10)


Something like this should work, you need to define it somewhere.

-edit-
To "use" it you would write:

Olivia "I said a line"

 

[Catapo]

I don't know a lot about ren'py but you are calling the strip() method on a variable called 'name' which is not defined because you named your variable 'olivia_name'.

 

[anne O'nymous]

I don't know a lot about ren'py but you are calling the strip() method on a variable called 'name' which is not defined because you named your variable 'olivia_name'.

Which is effectively the cause of the error.

$olivia_name = renpy.input("What is her name?", "Olivia", None, None, 10)

To fully reflect OP initial code, don't forget to strip the result :
$olivia_name = renpy.input("What is her name?", "Olivia", None, None, 10).strip()

 

[CarbonBlue]

That works, thanks guys!

 

[CarbonBlue]

OK wait maybe it's not quite working. If I choose No and don't change their names, it gives me a KeyError u/'olivia_name'. I apologize for my dumbness here, but is there a way to define the name after the name change, whether it was changed or not, so in my script I can write "o (for olivia or whatever is the new name) "hi blah blah"?

 

[recreation]

did you try the pass command?

menu:
    "Yes":
        do stuff
    "No":
        pass

 

[CarbonBlue]

Did not know about the pass command, I used a jump, which did the same thing. But I think the problem is in defining the name after I get past the option to change the name and the name change. Right now I have:

    menu:

        "Yes":
            python:
                angel_name = renpy.input("What is her name?", "Angel", None, None, 10).strip()

        "No":
            pass

    label angel_name_done:

        define a = Character("[angel_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])

But then when I do a new scene and "a "says something here"" it returns a KeyError.

 

[recreation]

define the character variables before the start label

define a = Character("Blabla")

...

label start:
    menu:
        "Yes":
            do stuff
        "no"
            pass
       
label nextScene:

 

[CarbonBlue]

Yep, have that. Still gives me the KeyError.

 

[recreation]

...

    label angel_name_done:

        define a = Character("[angel_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])

^there you have it in the label

 

[CarbonBlue]

I appreciate the help! Unfortunately, nope, that's not it either, lol.

 

[recreation]

how does your current code look?

 

[CarbonBlue]

define s = Character("[shannon_name]", color="#06DE10", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
define a = Character("[angel_name]", color="#A165F1", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
define o = Character("[olivia_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
define m = Character("[maeve_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])

define short_dissolve = Dissolve(0.5)
define medium_dissolve = Dissolve(1.0)

# The game starts here.

label start:

    # Show a background. This uses a placeholder by default, but you can
    # add a file (named either "bg room.png" or "bg room.jpg") to the
    # images directory to show it.

    scene scene1_1

    # This shows a character sprite. A placeholder is used, but you can
    # replace it by adding a file named "eileen happy.png" to the images
    # directory.

    # These display lines of dialogue.

    "Olivia" "OK girls I'm heading out to pick him up!"

    scene scene1_2

    "This is Mrs. Kelly. Her default name is Olivia. Would you like to change her name?"

    menu:

        "Yes":
            python:
                olivia_name = renpy.input("What is her name?", "Olivia", None, None, 10).strip()

        "No":
            pass

    #label olivia_name_done:

    #define o = Character("[olivia_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])


    scene scene1_3

    "Angel" "Pick who up, Mrs. Kelly?"

    "This is Miss Davis, a friend of the family. Her default name is Angel. Would you like to change her name?"

    menu:

        "Yes":
            python:
                angel_name = renpy.input("What is her name?", "Angel", None, None, 10).strip()

        "No":
            pass


    #define a = Character("[angel_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])


    scene scene1_4

    "Shannon" "Whom."

    scene scene1_5

    "This is the youngest daughter of the family. Her default name is Shannon. Would you like to change her name?"

    menu:

        "Yes":
            python:
                shannon_name = renpy.input("What is her name?", "Shannon", None, None, 10).strip()

                shannon_name = shannon_name.strip() or __("Shannon")

        "No":
            pass

    #label shannon_name_done:

    #define s = Character("[shannon_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])


    scene scene1_6

    a "Bitch."

That a "Bitch." is where it dies. Please excuse all the #'s as those are various attempts at fixes, heh.

 

[recreation]

define s = Character("[shannon_name]", color="#06DE10", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
define a = Character("[angel_name]", color="#A165F1", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
define o = Character("[olivia_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
define m = Character("[maeve_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])

define short_dissolve = Dissolve(0.5)
define medium_dissolve = Dissolve(1.0)

label start:

    scene scene1_1

    "Olivia" "OK girls I'm heading out to pick him up!"

    scene scene1_2

    "This is Mrs. Kelly. Her default name is Olivia. Would you like to change her name?"

    menu:

        "Yes":
            $ olivia_name = renpy.input("What is her name?", "Olivia", None, None, 10).strip()

        "No":
            pass


    scene scene1_3

    "Angel" "Pick who up, Mrs. Kelly?"

    "This is Miss Davis, a friend of the family. Her default name is Angel. Would you like to change her name?"

    menu:

        "Yes":
            $ angel_name = renpy.input("What is her name?", "Angel", None, None, 10).strip()

        "No":
            pass


    scene scene1_4

    "Shannon" "Whom."

    scene scene1_5

    "This is the youngest daughter of the family. Her default name is Shannon. Would you like to change her name?"

    menu:

        "Yes":
            $ shannon_name = renpy.input("What is her name?", "Shannon", None, None, 10).strip()

        "No":
            pass


    scene scene1_6

    a "Bitch."

 

[CarbonBlue]

Same problem.

 

[recreation]

Same problem.
View attachment 341862

The code I posted worked for me, try deleting all of the rpyc files (and only with them, not the rpy files). If it still doesn't work, then the problem must be somewhere else.

 

[polywog]

First ask the question "Do you want to name the characters or use default names?"
use default names as default
it's annoying as hell to be asked to name a bunch of characters, who you know nothing about all at once.
introduce the characters, and give a little info first before asking what they should be called.

 

[Porcus Dev]

Have you tried using "default" instead of "define"?

default s = Character("[shannon_name]", color="#06DE10", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
default a = Character("[angel_name]", color="#A165F1", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
default o = Character("[olivia_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])
default m = Character("[maeve_name]", color="#c8ffc8", who_outlines=[ (1, "#000000") ], what_outlines=[ (1, "#000000") ])

define short_dissolve = Dissolve(0.5)
define medium_dissolve = Dissolve(1.0)

# The game starts here.

label start:

    # Show a background. This uses a placeholder by default, but you can
    # add a file (named either "bg room.png" or "bg room.jpg") to the
    # images directory to show it.

    scene scene1_1

    # This shows a character sprite. A placeholder is used, but you can
    # replace it by adding a file named "eileen happy.png" to the images
    # directory.

    # These display lines of dialogue.

    "Olivia" "OK girls I'm heading out to pick him up!"

    scene scene1_2

    "This is Mrs. Kelly. Her default name is Olivia. Would you like to change her name?"

    menu:

        "Yes":
           $  olivia_name = renpy.input("What is her name?", "Olivia", None, None, 10).strip()

        "No":
            pass

    #label olivia_name_done:


    scene scene1_3

    "Angel" "Pick who up, Mrs. Kelly?"

    "This is Miss Davis, a friend of the family. Her default name is Angel. Would you like to change her name?"

    menu:

        "Yes":
            $ angel_name = renpy.input("What is her name?", "Angel", None, None, 10).strip()

        "No":
            pass


    scene scene1_4

    "Shannon" "Whom."

    scene scene1_5

    "This is the youngest daughter of the family. Her default name is Shannon. Would you like to change her name?"

    menu:

        "Yes":
            $ shannon_name = renpy.input("What is her name?", "Shannon", None, None, 10).strip()

                shannon_name = shannon_name.strip() or __("Shannon")

        "No":
            pass

    #label shannon_name_done:


    scene scene1_6

    a "Bitch."

In my code, the only character that can be renamed and uses a variable instead of text, I have it in "default", the others in "defines".

Sorry if I'm wrong because I'm not a great expert, but...
You use "define" for a constant, you can't change it if you don't use the command define again.
Using "default", it will be a variable that will react to the changes you indicate.

 

[CarbonBlue]

Deleted the rpyc files and still doesn't work. I started a new project and pasted only your code and get the same thing - note that this only happens if I select "no" for changing Angel's name (and in the other code it happens for the other women if I choose No on their name changes too).