I realized that
_persons in the code I quoted is actually an array of integers and not objects, so my point about your code is invalid and that's not the reason for the game freezing.
EDIT 1
After yet another look, I believe that the problem is with this part of the code:
JavaScript:
setup.getRandomPersonIds = function(persons, limit = 2) {
var randomIds = [];
var randomPersonList = clone(persons);
while (randomIds.length < limit && randomPersonList.length) {
var randomIndex = Math.floor(Math.random() * randomPersonList.length);
if (!randomIds.includes(randomIndex)) {
randomIds.push(randomIndex);
randomPersonList.splice(randomIndex, 1);
}
}
return randomIds;
};
Using something like
SugarCube.setup.getRandomPersonIds([3, 5], 2) can cause an infinite loop. In the code,
randomIndex is an integer that's either 0 or 1 (since
persons is a 2 element array here). So
randomIds is going to be filled with either 0 or 1 (which is not what you want, since you actually want it to be 3 or 5 in this example, but that's a separate issue).
The infinite loop happens if the first time through the loop,
randomIndex is 0. Now
randomPersonList has a length of 1 and so afterwards,
randomIndex will always be 0 and thus doesn't get pushed into
randomIds. So
randomIds stays with length 1 and the loop repeats.
Side note, but SugarCube's creator added many custom methods to the Array class, so that whole function could be written like so:
JavaScript:
setup.getRandomPersonIds = function(persons, limit = 2) {
return [].concatUnique(persons).randomMany(limit);
}
EDIT 2
Changing that function seems to have fixed the problem for me.
