I bought the game because some of the themes are right up my alley but after running into some bugs I decided to take a look under the hood so to speak and the code is a bit... odd.
The places with the bugs I looked at that have a style I have only seen when somebody with very little experience tries to extend stuff that already exists and does that by replicating what they already know or what is there already. Stuff that makes the code concise is missing and the places where mistakes can introduce bugs skyrocket. I haven't looked that much but this is a good example:
$lunchArousal is 6 or 6.5 or 7 or 7.5 or 8 or 8.5 or 9 or 9.5
this could be replaced with
$lunchArousal >= 6
Or this that is somewhat worse:
$lunchArousal is not 6 or 6.5 or 7 or 7.5 or 8 or 8.5 or 9 or 9.5
can be replaced with
$lunchArousal < 6
This is a really good example how a bug can get introduced - if any of the dots are missing this would still work but the value wouldn't trigger it anymore:
$lunchArousal is 6 or 6.5 or 7 or 75 or 8 or 8 or 9 or 9.5
Another thing I noticed was that frequently conditions that exclude each other are tested multiple times in a row - like those two conditions above that are mutually exclusive yet occur right next to each other. normally you use a if-else conditional structure there and its used plenty of times in the code just not in these odd places.
My guess we have more than one author of this stuff maybe the programming for the game was started by somebody somewhat competent and now somebody else tries to extend it who has not enough experience with programming in general.
From what I saw it doesn't seem at the point where it collapses under its own weight yet but whoever is expending it is probably taking an order of magnitude longer to do stuff and is making a lot of mistakes.
MSMRZZRS I assume you are the Author - maybe get help?
The places with the bugs I looked at that have a style I have only seen when somebody with very little experience tries to extend stuff that already exists and does that by replicating what they already know or what is there already. Stuff that makes the code concise is missing and the places where mistakes can introduce bugs skyrocket. I haven't looked that much but this is a good example:
$lunchArousal is 6 or 6.5 or 7 or 7.5 or 8 or 8.5 or 9 or 9.5
this could be replaced with
$lunchArousal >= 6
Or this that is somewhat worse:
$lunchArousal is not 6 or 6.5 or 7 or 7.5 or 8 or 8.5 or 9 or 9.5
can be replaced with
$lunchArousal < 6
This is a really good example how a bug can get introduced - if any of the dots are missing this would still work but the value wouldn't trigger it anymore:
$lunchArousal is 6 or 6.5 or 7 or 75 or 8 or 8 or 9 or 9.5
Another thing I noticed was that frequently conditions that exclude each other are tested multiple times in a row - like those two conditions above that are mutually exclusive yet occur right next to each other. normally you use a if-else conditional structure there and its used plenty of times in the code just not in these odd places.
My guess we have more than one author of this stuff maybe the programming for the game was started by somebody somewhat competent and now somebody else tries to extend it who has not enough experience with programming in general.
From what I saw it doesn't seem at the point where it collapses under its own weight yet but whoever is expending it is probably taking an order of magnitude longer to do stuff and is making a lot of mistakes.
MSMRZZRS I assume you are the Author - maybe get help?