Mod Ren'Py Onhold BadHero Multi-Mod [Ep2 v2.0.4p & Ep2 v3.2.4p & Specials][RiamMar / Charona]

T

Thovenaar

New Member
Feb 24, 2018
8
1
changing the lines in unren.bat worked.
changing the setting in line 108 from False to True in 00console.rpy worked.
Your _console.rpy did not work because you used config.developer instead of config.console.
Thanks for the quick response , and for the mod . It realy is a great mod.
 
  • Heart
Reactions: RiamMar
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
Thovenaar said:
changing the lines in unren.bat worked.
changing the setting in line 108 from False to True in 00console.rpy worked.
Your _console.rpy did not work because you used config.developer instead of config.console.
Thanks for the quick response , and for the mod . It realy is a great mod.
Click to expand...
Ha! I said the one thing and did the other. ^_^
Fixed my file and re-upped it.

Thanks for testing this for me and your kind words. Glad it works.
 
N

Normdk

Newbie
Jul 27, 2020
38
86
Hey RiamMar

Thank you for the mod.
Try as I might, I keep having Mod Core v3.0 for Episode 2 - v2.4.4p or Earlier, and I cant seem to get the Walkthrough to work.
I tried making sure everything was fresh installed, game as well as mod - and I have tried downloading from all the avaible links (GitLab, Google Drive, MediaFire and Mega - the files.fm doesnt appear avaible as it is unclickable)

The game shows version 2.5.4p, but it keeps saying the mod is 2.4.4p, and it doesnt appear to show me the walkthrough at all - even on old saves as well as on a new game.

Any idea what I got that conflicts with the process?

I just tested out your mod for Episode 1, and it works flawless.
I got WT and consequenses for choices etc.

Thank you for your work :)

You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.

--EDIT--

I tried Extracting RPA packages, and now I have options regarding the WT working.
It still insist it is Core v3.0 for v2.4.4p though.
You don't have permission to view the spoiler content. Log in or register now.
 
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
Normdk said:
Hey RiamMar

Thank you for the mod.
Try as I might, I keep having Mod Core v3.0 for Episode 2 - v2.4.4p or Earlier, and I cant seem to get the Walkthrough to work.
I tried making sure everything was fresh installed, game as well as mod - and I have tried downloading from all the avaible links (GitLab, Google Drive, MediaFire and Mega - the files.fm doesnt appear avaible as it is unclickable)

The game shows version 2.5.4p, but it keeps saying the mod is 2.4.4p, and it doesnt appear to show me the walkthrough at all - even on old saves as well as on a new game.

Any idea what I got that conflicts with the process?

I just tested out your mod for Episode 1, and it works flawless.
I got WT and consequenses for choices etc.

Thank you for your work :)

You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.

--EDIT--

I tried Extracting RPA packages, and now I have options regarding the WT working.
It still insist it is Core v3.0 for v2.4.4p though.
You don't have permission to view the spoiler content. Log in or register now.
Click to expand...
Ohhhh. The mod core and game version are hardcoded. Don't ask me, I just changed it and will post a fix.
I'll have a quick look to see if I can get the ModCore 4 injection method working, that should be able to fix the rpa/rpy problem. Please give me a few minutes.
 
  • Like
Reactions: Normdk
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
Normdk said:
Hey RiamMar

Thank you for the mod.
Try as I might, I keep having Mod Core v3.0 for Episode 2 - v2.4.4p or Earlier, and I cant seem to get the Walkthrough to work.
I tried making sure everything was fresh installed, game as well as mod - and I have tried downloading from all the avaible links (GitLab, Google Drive, MediaFire and Mega - the files.fm doesnt appear avaible as it is unclickable)

The game shows version 2.5.4p, but it keeps saying the mod is 2.4.4p, and it doesnt appear to show me the walkthrough at all - even on old saves as well as on a new game.

Any idea what I got that conflicts with the process?

I just tested out your mod for Episode 1, and it works flawless.
I got WT and consequenses for choices etc.

Thank you for your work :)

You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.

--EDIT--

I tried Extracting RPA packages, and now I have options regarding the WT working.
It still insist it is Core v3.0 for v2.4.4p though.
You don't have permission to view the spoiler content. Log in or register now.
Click to expand...
Using part of ModCore 4 didn't work, as I expected. But hope dies last...

  • Updated the ModCore 3 WT injection method
  • Changed folder name to not include the ModCore name and version for easier updates in the future.
  • Should work with rpa, extracted rpy and rpyc only
    • Probably APK save, if someone wants to port it. Give me a message if you do and it's not working.
  • Removed hardcoded version info
Please delete the old mods folder first before installing the new version!
 
  • Like
Reactions: Normdk
N

Normdk

Newbie
Jul 27, 2020
38
86
RiamMar said:
Using part of ModCore 4 didn't work, as I expected. But hope dies last...

  • Updated the ModCore 3 WT injection method
  • Changed folder name to not include the ModCore name and version for easier updates in the future.
  • Should work with rpa, extracted rpy and rpyc only
    • Probably APK save, if someone wants to port it. Give me a message if you do and it's not working.
  • Removed hardcoded version info
Please delete the old mods folder first before installing the new version!
Click to expand...
Works like a charm :)
Thank you for the quick response.
 
  • Like
Reactions: RiamMar
suckassonline

suckassonline

Member
Jun 1, 2020
155
46
I'm sorry, but an uncaught exception occurred.

While running game code:
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 1, in script
init python:
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 1, in script
init python:
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 446, in <module>
riamMar = RiamMar ()
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 33, in __init__
self.preparePersistentData ()
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 360, in preparePersistentData
f.name = f2.name = value
NameError: global name 'f' is not defined

-- Full Traceback ------------------------------------------------------------

Full traceback:
File "renpy/bootstrap.py", line 326, in bootstrap
renpy.main.main()
File "renpy/main.py", line 515, in main
renpy.game.context().run(node)
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 1, in script
init python:
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 1, in script
init python:
File "renpy/ast.py", line 923, in execute
renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
File "renpy/python.py", line 2235, in py_exec_bytecode
exec(bytecode, globals, locals)
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 446, in <module>
riamMar = RiamMar ()
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 33, in __init__
self.preparePersistentData ()
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 360, in preparePersistentData
f.name = f2.name = value
NameError: global name 'f' is not defined

Windows-10-10.0.22621
Ren'Py 7.4.8.1895
Bad Hero 2.0.4p
Fri Jun 2 18:43:24 2023

or if anyone know how to fix it lmk plz
 
Last edited:
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
suckassonline said:
I'm sorry, but an uncaught exception occurred.

While running game code:
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 1, in script
init python:
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 1, in script
init python:
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 446, in <module>
riamMar = RiamMar ()
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 33, in __init__
self.preparePersistentData ()
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 360, in preparePersistentData
f.name = f2.name = value
NameError: global name 'f' is not defined

-- Full Traceback ------------------------------------------------------------

Full traceback:
File "renpy/bootstrap.py", line 326, in bootstrap
renpy.main.main()
File "renpy/main.py", line 515, in main
renpy.game.context().run(node)
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 1, in script
init python:
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 1, in script
init python:
File "renpy/ast.py", line 923, in execute
renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
File "renpy/python.py", line 2235, in py_exec_bytecode
exec(bytecode, globals, locals)
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 446, in <module>
riamMar = RiamMar ()
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 33, in __init__
self.preparePersistentData ()
File "game/RiamMar_ModCore_3.02/core/RiamMar.rpy", line 360, in preparePersistentData
f.name = f2.name = value
NameError: global name 'f' is not defined

Windows-10-10.0.22621
Ren'Py 7.4.8.1895
Bad Hero 2.0.4p
Fri Jun 2 18:43:24 2023

or if anyone know how to fix it lmk plz
Click to expand...
Just crawled out of bed. Sooo, good morning! :D

Did you try to change the name in the mod menu before starting or loading a game?

Edit: Sadly, I couldn't reproduce this error on my end. But I tried to add a check for "f" and "f2" Can you try this fix?
 
Last edited:
suckassonline

suckassonline

Member
Jun 1, 2020
155
46
RiamMar said:
Just crawled out of bed. Sooo, good morning! :D

Did you try to change the name in the mod menu before starting or loading a game?
Click to expand...
i didnt i add the mod to the game after checking game will run clean then this report
also good morning
 
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
suckassonline said:
i didnt i add the mod to the game after checking game will run clean then this report
also good morning
Click to expand...
Here is a work around fix that checks if f and f2 exist.
This should prevent the error in case the character objects don't exist. If it looks as if the renaming didn't work, this fix prevented the change and you will have to change it again. Best would be, if you wait for the prompt in game but it shouldn't really matter where you do it.

Also, the mod is meant to be with the RPA file. So in case you used unren, please make a copy without unren to use the mod with. Episode 2 should be fine either way.
 
suckassonline

suckassonline

Member
Jun 1, 2020
155
46
RiamMar said:
Here is a work around fix that checks if f and f2 exist.
This should prevent the error in case the character objects don't exist. If it looks as if the renaming didn't work, this fix prevented the change and you will have to change it again. Best would be, if you wait for the prompt in game but it shouldn't really matter where you do it.

Also, the mod is meant to be with the RPA file. So in case you used unren, please make a copy without unren to use the mod with. Episode 2 should be fine either way.
Click to expand...
still getting f is not defined, i ran a clean game no unren or anything just the base game, put the fix u posted in ur mod then mod in game go the error, is there something i can do in the raimmar file to fix it? is there something i should do in game before putting the mod in?

edit: where can i define "f" is it in a base game file idk if i should mention this but this is ep1 and yes i dl ep1 mod

Edit:
def preparePersistentData (self):
global f, f2
renpy.save_persistent ()
settings = {
"family" : True,
"kineticNovel" : False,
"kineticNovelAllCumshots" : False,
"kineticNovelCanon" : False,
"kineticNovelNTR" : False,
"mcName" : "Frank",
"minigameTimer" : False,
"modQuicknav" : True,
"modTextbox" : True,
"opacityCompletion" : 0.6,
"opacityGuide" : 0.6,
"opacityLabels" : 0.6,
"opacityQuicknav" : 0.6,
"showCollectibles" : True,
"showCompletion" : False,
"showEvents" : True,
"showFreeroamEnd" : True,
"showFreeroamFF" : True,
"showGuide" : True,
"showLabels" : True,
"showQuiz" : True,
"showTooltips" : True,
"showWalkthrough" : True,
"showShufflePuzzle" : True,
"shufflePuzzleAutoWin" : True

maybe this is where it needs to be define?

edit: i also started the game to where the mc name comes in then added the mod still the same issue
 
Last edited:
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
suckassonline said:
still getting f is not defined, i ran a clean game no unren or anything just the base game, put the fix u posted in ur mod then mod in game go the error, is there something i can do in the raimmar file to fix it? is there something i should do in game before putting the mod in?

edit: where can i define "f" is it in a base game file idk if i should mention this but this is ep1 and yes i dl ep1 mod

Edit:
def preparePersistentData (self):
global f, f2
renpy.save_persistent ()
settings = {
"family" : True,
"kineticNovel" : False,
"kineticNovelAllCumshots" : False,
"kineticNovelCanon" : False,
"kineticNovelNTR" : False,
"mcName" : "Frank",
"minigameTimer" : False,
"modQuicknav" : True,
"modTextbox" : True,
"opacityCompletion" : 0.6,
"opacityGuide" : 0.6,
"opacityLabels" : 0.6,
"opacityQuicknav" : 0.6,
"showCollectibles" : True,
"showCompletion" : False,
"showEvents" : True,
"showFreeroamEnd" : True,
"showFreeroamFF" : True,
"showGuide" : True,
"showLabels" : True,
"showQuiz" : True,
"showTooltips" : True,
"showWalkthrough" : True,
"showShufflePuzzle" : True,
"shufflePuzzleAutoWin" : True

maybe this is where it needs to be define?

edit: i also started the game to where the mc name comes in then added the mod still the same issue
Click to expand...
f and f2 are from the game itself and two "Frank" characters for different uses. Defining them in my mod wouldn't be proper. :)

The characters are defined in the "imageside.rpy". The problem is, that to change those files, you have to unren and then the mod won't be able inject the walkthrough.
There's an init statement in that file, so maybe that's somehow interfering? I changed the init order in my mod to 10 and 12, so that it definitely loads after the "imageside.rpy" of the game and therefor after the definition of f and f2. Can you please try it out?

Edit: To be honest, I had to reinstall my PC not long ago and lost all my saves etc. So Ep1 is a clean install for me as well and it worked first try. I know there was a similar problem early on, when I made the mod. if this version below doesn't work, I will have to look what it was back then. Maybe it's a similar issue.

Edit2: Found the other post about this problem. The fix I did back then didn't get a reply. Did you put in the "mods" folder or the "RiamMar..." folder? I could reproduce the error, when I placed the "RiamMar..." folder directly into the game folder. So, if that's the case for you, I hope this solves it. :D
Stick with the original "load order" version of the mod, just to be save, if using the "mods" folder works, just to be on the save side and not introducing problems with the changed load order.
 
Last edited:
suckassonline

suckassonline

Member
Jun 1, 2020
155
46
RiamMar said:
f and f2 are from the game itself and two "Frank" characters for different uses. Defining them in my mod wouldn't be proper. :)

The characters are defined in the "imageside.rpy". The problem is, that to change those files, you have to unren and then the mod won't be able inject the walkthrough.
There's an init statement in that file, so maybe that's somehow interfering? I changed the init order in my mod to 10 and 12, so that it definitely loads after the "imageside.rpy" of the game and therefor after the definition of f and f2. Can you please try it out?

Edit: To be honest, I had to reinstall my PC not long ago and lost all my saves etc. So Ep1 is a clean install for me as well and it worked first try. I know there was a similar problem early on, when I made the mod. if this version below doesn't work, I will have to look what it was back then. Maybe it's a similar issue.

Edit2: Found the other post about this problem. The fix I did back then didn't get a reply. Did you put in the "mods" folder or the "RiamMar..." folder? I could reproduce the error, when I placed the "RiamMar..." folder directly into the game folder. So, if that's the case for you, I hope this solves it. :D
Stick with the original "load order" version of the mod, just to be save, if using the "mods" folder works, just to be on the save side and not introducing problems with the changed load order.
Click to expand...
fixed i was putting in the riammar folder in and when i put the mods folder it loaded.

thank you so much for working through this with me and thank you for all you do, its people like you that make playing these game just a bit more enjoyable. i wish you all the best.
 
  • Like
Reactions: RiamMar
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
suckassonline said:
fixed i was putting in the riammar folder in and when i put the mods folder it loaded.

thank you so much for working through this with me and thank you for all you do, its people like you that make playing these game just a bit more enjoyable. i wish you all the best.
Click to expand...
Thanks for your kind words! You're very welcome.
 
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
calel said:
https://f95zone.to/threads/bad-hero-ep-2-v2-6-4p-xlab.19961/ please update your mod if you have time
Click to expand...
Downloading and having a look.

For those that can't wait:
Do Quest > Buy fridge > Use canister > Finish off or Pity > Pick relation

It says "Relation with X On/Off" as choice but should probably be "Play scene with X" and "Finish Quest". So no worries, there are no such variables set except for having played the scene.

Status: Uploaded! Have fun!
 
Last edited:
  • Like
Reactions: GGGanon and DragonsFear
RiamMar

RiamMar

One Hand Clapping, Heart of the Keyforge
Modder
Game Developer
Sep 15, 2017
1,002
3,797
ReaperZ0ne said:
View attachment 2800222
replay room doesn't work
Click to expand...
The replay_room is not made by me or part of the mod. There are also no replay labels present in the game anymore, as far as I can see.
It looks like Xlab removed the replay function from the game but forgot to hide the button in the menu.
Nope, forget what I said. Just had first coffee today and checked again. The reworked the main menu and I'm overwriting it with my mod, since I didn't check the unmodded game. :D

Going to switch to the new menu now.

Updated and uploaded my mod to reflect the changes made by Xlab .
 
Last edited:
  • Like
Reactions: DisabledAccount1110202308
You must log in or register to reply here.
Top Bottom