Checked, and sure that traits in Ver 0.2 and 0.15b are all only first letter capitalized. Any programming to take advantage of this to avoid error/crashes is welcome.
Last edited:
- Jul 17, 2019
- 2,295
- 964
Like I said:
That someone is not necessarily Goldo. For example, _neronero's Trait King has a trait called 'Strong Gag Reflex', and at least intermediate versions of Bonanza also had mixed formats. Writing code that only fixes the immediate issue or assumes a given input format for no specific reason is never a good idea.
- Nov 17, 2019
- 252
- 104
Traits are saved in a data structure named trait_dict. You can create a list of of the keys of this dict and compare text to text in a cap insensitive manner.
And then you can fix the capitalization, WhAtEveR iT Is, on a case by case basis.
This is NOT rocket science. A decent high school student could write this.
O-
- Jul 17, 2019
- 2,295
- 964
Which is not necessarily static. E.g. _neronero's Fran pack tried to play with adding dynamically created traits; and I had no end of trouble in Bonanza because I added a modified form of Trait King and regenerated the whole trait dictionary. So when you create these lists can matter, and a girl can perchance have traits outside of that list.
Edit: Also, 0.15b - which is still the main release - has some traits (Godless and the four you get for losing a girl's virginity) outside of that dictionary.
Which is exactly what I suggested earlier.
No real need to create that list, either, because in the worst case it might get changed due to mods etc afterwards. And the performance increase is marginal. So you can just use trait_dict.keys() directly.
Note that Ren'Py still uses Python 2, where lowercase conversion is somewhat iffy if you have 'exotic' characters in your text, like Greek or ß.
Uh, the whole point of this exercise is not to have to do that, right?
You could also put the whole thing into a try-catch block, so the game won't do a 'hard' crash on mistakes.
You're right that it's not rocket science, but there are several nuances here that can be solved now, instead of ignored and then reinvented by the unlucky souls who try the trainer on e.g. Trait King 0.2 if that ever comes out.
Last edited:
- Nov 17, 2019
- 252
- 104
I'd rather code than talk.
one implementation. Suitable for the init section of code derived from kite80's original trainer.
Code:
def gSanitizeTrait(mytrait):
matchcount = 0
sanitized = ""
tlen = len(mytrait)
for key in trait_dict:
kk = key
kl = len(key)
if kl > tlen:
kk = kk[:tlen]
if kk.casefold() == mytrait.casefold():
matchcount += 1
sanitized = key
if matchcount > 1:
sanitized = ""
return sanitized
Last edited:
- Jul 17, 2019
- 2,295
- 964
Python 2 does not have casefold(), at least not without extra work.
You might want to do a precise match as well and break the loop if it happens, right now you're iterating over the whole trait dictionary all of the time. Not that it matters all that much.
Otherwise, looks good.
Edit:
You might want to do a precise match as well and break the loop if it happens, right now you're iterating over the whole trait dictionary all of the time. Not that it matters all that much.
Otherwise, looks good.
Edit:
Not that it's very important in hobby projects like these, but this kind of attitude is actually a pretty big problem in serious software development.
Last edited:
- Jan 23, 2021
- 285
- 393
Seeing my name mentioned here makes me wonder...Apparently I'm right below the level of a decent high school student, an exemplary problem case for actual programmers.
Probably not something to be proud of... But the fact you can contribute mods/events/stories without much programming experience is just another thing to like about Brothel King. Certainly very underutilised, despite Goldo welcoming it with open arms.
I guess it's slightly too complicated for someone with 0 experience, but slightly too limiting for someone with too much experience (quickly leading to a fork)?
- Jul 17, 2019
- 2,295
- 964
Nah, Trait King is certainly something you can be proud of. Most of my troubles were self-inflicted. I could have chosen to fully integrate TK into my mod, but was too lazy to do it.
Definitely.
I have (or had) nearly zero experience as well. Forking was just the natural consequence of me wanting to retouch everything. A professional would probably not have done that. On the other hand, a professional would most likely find entertainment in the non-programming parts, like Leortha does.
- May 30, 2017
- 1,082
- 1,079
People can start from 0 and contribute to BK in any way they see fit for their availability, and trust me when I say it's almost the same thing if you have some basic dev skills or are a total newbie, in both cases you have to learn almost everything from scratch. Moreover, here you can find other people who can help you learning ren'py, enough to make your own events and mods, the only real limits are how much time you can spend on it and if you wish it or not.
- Sep 28, 2017
- 2,665
- 6,964
So I downloaded the game and added the patch and basic girl pack. The images of girls keep chaning every time I look at them (i.e. one time it is sakura from naruto, other time it is someone from bleach). The small images do not match the big image as well. Is it supposed to be ever changing like that or do I have a bug somewhere?
- May 30, 2017
- 1,082
- 1,079
Portraits and profiles are different, it is meant to be like that; also portraits of girls in the brothel may change every time you open brothel screen. You will notice that this doesn't happen for market slaves and free girls, so that you can easily reckognize them anytime
- Jul 17, 2019
- 2,295
- 964
If 'every time' is every day, that's intended. Girls get up in the morning and pick different clothing, or makeup, etc.
If it's every time you click a button ('Girls', 'Slave market', 'Farm', etc), it's a bug.
Portraits and profiles are different files, since Ren'Py does not have an advanced AI zoom feature. And most people don't crop portraits based on profiles, because it's a lot of work.
- Sep 28, 2017
- 2,665
- 6,964
I see. That kinda sucks to me because I just cannot anchor the girl in my imagination when she keeps switching between completely different characters. Oh well.
- Jul 17, 2019
- 2,295
- 964
Wait, wait. Different characters? Can you provide an example screenshot? The whole point of girl packs is that it's the same character, but different pictures of her. The only times this is not the case is if the pack maker fucked up, or you have default pictures enabled, which are generally anonymised, even if hardcore fans can still occasionally recognise a few of the pictures.
Cropping is the one big type of editing that I actually do. I know there are other pack makers who talk about editing out watermarks and sigs and such, but to me those are way too much work. Cropping is easy. As for Portraits, if I don't have 5-10 naked and another 5-10 non-naked for each pack, I always copypasta and then crop down images from the pack to make those.
There exist a handful of packs based around a race instead of around a character. Someone did a blue slime-girl pack a good while back, and I know that a couple of WOW races have had packs made. And my recently released Pikachu-girl pack would fit in there. And I keep thinking of doing an ES Argonian pack some day. (Katia from Prequel satisfied my urge to do a Kahjit pack). But there are very few like this. Single digits worth. And I don't think that's what is being referred to here.
- Sep 28, 2017
- 2,665
- 6,964
Sure. This is the same character, I only pressed end day and this is the way their picture changed.
I followed the instructions in the installation as stated in OP to the letter, then started the game.
EDIT: Okay, my dumbass just put the whole folder with the girl pack into the girls folder, so the game took it as every picture is the same girl, so I guess it just kept pulling from the whole pool.