There's a weird game load crash happening with the code in the dev branch right now:
Code:
Location: start
Area: on visit
Line: 19
Code: 111
Desc: Location not found!
Based on the error I naturally looked in start.qsrc. I didn't see any issues with line 19 in that file, but line 20 seems to be calling a location file that doesn't actually exist:
You must be registered to see the links
I commented out that line and sure enough the game didn't crash when loading it. I wondered why the crash was only happening now though since start.qsrc hasn't actually been modified in months, so that line couldn't be the only cause of the current crash. Looking through recent commits I noticed mey_home.qsrc was recently modified, and there's a closing quote missing on one of the modified lines:
You must be registered to see the links
Adding the missing quote also stops the crashing even with the line in start.qsrc uncommented.
While the missing quote in mey_home.qsrc seems to be the main cause of the crash, maybe that line in start.qsrc should be removed also since it's calling a non-existent location and apparently hiding the true source of errors.
Edit: Clearly I don't understand how addbuilddate works. I'm guessing it's some kind of internal QSP location/function? I can see that with it commented out it doesn't show the build date in the main menu, but it's not clear to me where it's being called from or why commenting that line out stopped the crash earlier, but somebody pushed a fix for the missing closing quote so the crash is gone now.
Edit 2: I can see now that addbuilddate is being written to the bottom of glife.txt by txtmerge.py before it's compiled into the qsp file. Still not sure why it was masking the source of the crash, but I guess it doesn't really matter at this point.