Ninoss - Hi, found few more bugs, so in case you haven't fixed them yet.
Events cannot load start.webp.
It is there probably since previous version. In
eventSetup.rpy
the condition
os.path.isfile(selectedEvent.directoryPath + "start.webp")
results in
false
even if the start.webp is there, which it should be based on your guidelines. I guess the python slightly changed. Fixed by using
renpy.loadable("start.webp", selectedEvent.directoryPath)
instead.
Vanilla main tags don't correspond to code.
You build yourself a trap there. Going through the code searching for usage of
webmFinder.get
, I found 34 different main tags, but when I add the missing one to the
vids/_mainTags.txt
and fixed some of them, some of my girl's videos have been suddenly unregistered during reloading. The missing one is
remove_dress
, also the
strip
should be
strip_panty
according to the code. Maybe you are planning to remove
remove_socks
as both places (
lb_examevents.rpy labels event_removeSocks & event_removePantyhose
) that use it are commented. After some debugging, I found the culprit in the
webmFinder_ren.py: Webm.loadPossibleTags
function.
Firstly, there are two incorrect things:
_vanillaGameNbOfTags = 33
, which should be 34 as counted in the code, unless you forgot to remove the remove_socks
tag.
if line != "" and i < _vanillaGameNbOfTags-1:
, just drop the '-1' at the end, as you're checking indicies, the exclusive '<' is enough to include the last one. Like this, by adding the one missing tag, it removed the last two tags from the file.
Secondly, I know you made a code that recongnises new tags from vids and add it to the file, but do you really need a function that clean up the file to a vanilla state? If a modder adds a new tag, they would like to keep it, or at least they are responsible for their own mess. This function just mess things up during loading and reloading. Like this you just need to remember to edit it if you decide to change vanilla tags and as you see, they already don't correspond.
Other stuff I “fixed”, which would be nice if you fix too.
Since it is in academic grounds, you could at least fix the punctuation in speaches. You do not put a space before a dot, so why you put it before question and exclamation marks? Sometimes even before a comma. There should be
no space before them. It can be searched using a regex so it is not so hard to replace them. Also there is only one dot, or ellipsis (…) which is just one character and the dots are closer to each other than when you are using three dots. So don't use just two dots, and similarly (just for emphasis) don't use two '?' or '!', but just one or three. More of them does not equal stronger emphasis, but higher level of stupidity.
Also in English the currency signs '$', '€' and '£' are placed before the amount unspaced. The € can be placed after the amount in other languages, but it is more or less just tolerated as it is based on rules of the country's former currency. I think you might be influenced by French culture regarding this, but '$' should still go before the amount.