I was referring to the original final version from Amaraine cause the code does look like it makes sense but when I try to dismiss a girl that falls into the condition check class_in_play() then try to recruit the dismissed girl back into the roster it doesn't work for me
You are not the only one to find that odd cause this is definitely odd and the game should not be happening this way
I am not sure if your remastered version is having this same odd behavior I was pointing out the problems I have experienced in my original final version of the game in case someone might run into this issue
If the remastered version is using the same condition checks or similar codes to remove a girl from the roster then this issue could be something to look out for down the road
I can explain this with screenshots but the screenshots are too large I have to divide this up:
Screenshot 1 Loaded save file with plenty of gold and the Paladin is in the roster
The condition check not class_in_play("Paladin") has been removed
Screenshot 2 I went to dismiss the Paladin and the Paladin was removed from the roster
The condition check not class_in_play("Paladin") has been removed
Screenshot 3 I used 4 Hyper Revitalizing Potions to clear the amount of rest days for the girls
The condition check not class_in_play("Paladin") has been removed
Screenshot 4 I try going to the temple to recruit the Paladin and the option for Recruit a Paladin is available
The condition check not class_in_play("Paladin") has been removed
Screenshot 5 I closed the game changed the plains.rpy file to check for not class_in_play("Paladin")
I repeated screenshot 1 and screenshot 2 and then I used 4 Full Revitalizing Potions to clear the rest days
Screenshot 6 I went to the temple to try and recruit the Paladin again but this time the option for Recruit a Paladin is unavailable
Screenshot 7 I tried max_roster_length = 10 and I also changed it to max_roster_length = 12 to ensure the conditions are met in the original final version from Amaraine
I did not close the game
The condition check not class_in_play("Paladin") is still in the plains.rpy file
Screenshot 8 I have plenty of gold so the condition check for gold is definitely not an issue
Again I did not close the game
The condition check not class_in_play("Paladin") is still in the plains.rpy file