Holy fuck no wonder this mod has so many bugs and install issues.
Install issues and confusion
If we look at the patch / bug fix I posted on LR2's forum it does just that it simply updates the files that are different from 39.1 and 39.3 and corrects a few bugs that are in the code. In fact the bugs I found were submitted in so he could fix them directly.
Most were simple issues like added or missing variable or using an S on the end of variable name that didn't have it.
The so called patch bug fix listed on the front of this forum is more accurately a full on mod. While few files are duplicates of the original files that isn't true for most of them. Changes range from as small as the carriage return being changed to spelling and grammar corrections to full on code changes that were not needed. Then you have full on additions to the code.
So no wonder you have people having issues making the mod work. They have to download the original file put your so called patch bug fix in then apply the mod pack over the top of that.
It would have caused a million times less confusion for users if this so called mod and bug patch was just built the hell into the mod. Then they could do it all with just a single download. It makes a million times more sense because the mod won't work without it.
Instead what you have is people downloading the base game. Getting it actually patched to the original games thing then seeing your so called bug fix patch and going well I already got that so don't need it. Then trying to install the mod.
In the end what they really created was a mod that you have to install first to install the larger mod pack.
Lets get back to the bugs part of this.
You effectively have now created a forked line of the core of the game which you will either have to keep updating a copy of or you will be forced to go back and start building your mod to actually work off the real base code.
That means not only do you have to keep track of the forked line of code but the changes to the original so long as the forked base has to be installed over the old system. The reason there is any time he adds features and files into the code that you don't have in the forked code you are going to be left dealing with it.
I just used win merge to look at current versions in question with a comparison. Its laughable to say the least.
The core comparison is 95% or so yellow. You created your own nightmare of work.
Your best option. Is to actually go back to the core being the core. Submit actual patches that fix just what is broken the way the developer intend it and so it gets into his updates. Then build the mods onto it. If not this nightmare of coding will grow to a point it won't be easily manageable or compatible with the original game. Your patches will get more and more unwieldy.
You also defeated the purpose of how you chose to make the mods to start with.
https://f95zone.to/threads/lab-rats-2-mods.32881/post-5595518
You mod isn't mostly compatible right out the box.
That also means someone like myself who built his mod based on the actual base game code would have to then worry about what you put in the update bug fix.
Way to violate your own principles.
The ability of being able to simply remove the mod folder and return to the pure base game is gone.
Carriage returns
It might not seem like a big deal but it can cause issues at times. Mac by default use <cr> or '\r' , linux uses <LF> or '\n' , windows by default uses <CR><LF> or '\r\n' It's actually better to make sure you use the windows method because it works across all 3 systems.
depending on the method used to detect the end of line it can cause issues.
Why am I bringing that up. You have a lot of files that have been modified to just end with '\n' <LF> probably done on a linux system. Those files are in the so called patch bug fix.
Install issues and confusion
If we look at the patch / bug fix I posted on LR2's forum it does just that it simply updates the files that are different from 39.1 and 39.3 and corrects a few bugs that are in the code. In fact the bugs I found were submitted in so he could fix them directly.
Most were simple issues like added or missing variable or using an S on the end of variable name that didn't have it.
The so called patch bug fix listed on the front of this forum is more accurately a full on mod. While few files are duplicates of the original files that isn't true for most of them. Changes range from as small as the carriage return being changed to spelling and grammar corrections to full on code changes that were not needed. Then you have full on additions to the code.
So no wonder you have people having issues making the mod work. They have to download the original file put your so called patch bug fix in then apply the mod pack over the top of that.
It would have caused a million times less confusion for users if this so called mod and bug patch was just built the hell into the mod. Then they could do it all with just a single download. It makes a million times more sense because the mod won't work without it.
Instead what you have is people downloading the base game. Getting it actually patched to the original games thing then seeing your so called bug fix patch and going well I already got that so don't need it. Then trying to install the mod.
In the end what they really created was a mod that you have to install first to install the larger mod pack.
Lets get back to the bugs part of this.
You effectively have now created a forked line of the core of the game which you will either have to keep updating a copy of or you will be forced to go back and start building your mod to actually work off the real base code.
That means not only do you have to keep track of the forked line of code but the changes to the original so long as the forked base has to be installed over the old system. The reason there is any time he adds features and files into the code that you don't have in the forked code you are going to be left dealing with it.
I just used win merge to look at current versions in question with a comparison. Its laughable to say the least.
The core comparison is 95% or so yellow. You created your own nightmare of work.
Your best option. Is to actually go back to the core being the core. Submit actual patches that fix just what is broken the way the developer intend it and so it gets into his updates. Then build the mods onto it. If not this nightmare of coding will grow to a point it won't be easily manageable or compatible with the original game. Your patches will get more and more unwieldy.
You also defeated the purpose of how you chose to make the mods to start with.
https://f95zone.to/threads/lab-rats-2-mods.32881/post-5595518
You mod isn't mostly compatible right out the box.
That also means someone like myself who built his mod based on the actual base game code would have to then worry about what you put in the update bug fix.
Way to violate your own principles.
The ability of being able to simply remove the mod folder and return to the pure base game is gone.
Carriage returns
It might not seem like a big deal but it can cause issues at times. Mac by default use <cr> or '\r' , linux uses <LF> or '\n' , windows by default uses <CR><LF> or '\r\n' It's actually better to make sure you use the windows method because it works across all 3 systems.
depending on the method used to detect the end of line it can cause issues.
Why am I bringing that up. You have a lot of files that have been modified to just end with '\n' <LF> probably done on a linux system. Those files are in the so called patch bug fix.
Last edited:
