Tool Ren'Py UnRenGUI, UnRen-forall(v9.4), UnRen-Powershell-forall(v9.4), UnRen-old

5.00 star(s) 3 Votes

Madeddy

Well-Known Member
Dec 17, 2017
1,016
735
244
Wow, please get your hand checked out if possible. I hope everything is OK and it's just some temporary pain. Glad you got some time outside.
Yeah, i agree. Lets hope.

Do you think this bit here will fix this bug with Our Bright Days decompilation?
Cannot check atm because i dont get even to your bug. I have another error if i use the v1.2.0 decompiled files from this game. And i think it will perhaps soon bring even more "fun": The changelog of renpy shows new revertable classes... o_O
 
Last edited:
  • Like
Reactions: yoyomistro

yoyomistro

Engaged Member
Jan 15, 2017
3,136
4,697
445
Yeah, i agree. Lets hope.

Cannot check atm because i dont get even to your bug. I have another error if i use the v1.2.0 decompiled files from this game.
There was another issue I ran into with that title decompiled with passing **kwargs into a list; the shopping list code passes **kwargs and that causes errors when running decompiled.

You don't have permission to view the spoiler content. Log in or register now.
 

VepsrP

Well-Known Member
Modder
Dec 13, 2017
1,387
1,430
391
Support for changes to the "AttackOnSurveyCorps" game engine has been added. The game starts. I suggest that people interested in the game check the rest.:BootyTime:
 

VepsrP

Well-Known Member
Modder
Dec 13, 2017
1,387
1,430
391
Nah. I got this already.
I steal sometimes your code, now you get mine. How did "Jack O`Neil" put it? "Togetherness is gooood." :p
I put it in my GH or post it here.
I've looked at your changes. It was all cool, of course, but I thought of doing it that way. :BootyTime: But none of this makes any sense at all.:HideThePain: As I said, they completely redesigned the parameter system. They used a different type of dictionary(OrderedDict). Added typing to the parameters, as in python itself. An approximate solution can be found on my GitHub.
 

Twistty

The Happy Beaver
Donor
Respected User
Former Staff
Sep 9, 2016
4,389
40,479
694
UnRen-forall v9.1
Wow - that was way faster than I expected!
How many past versions of Ren'Py does this v9.1 work til?
7.3.5 or just 8.0.1?

Thanks VepsrP (y)
 

Madeddy

Well-Known Member
Dec 17, 2017
1,016
735
244
...but I thought of doing it that way. :BootyTime: But none of this makes any sense at all.:HideThePain: As I said, they completely redesigned the parameter system....
That's totally OK with me. If this works better for you. :coffee:

But it makes sense i think. I noticed that is with "positional" the same behavior and code area we had with "extrakw" and "extrapos", so i tested it with the same solution there which works for now without much hassle.

This is how in see it whats going on with all this:
1. Nearly 2 years ago they began to work on this parameter stuff. "extrakw" etc. was either "None" or with a value, but always there. After the change they are allowed to be missing, so it banged with the old code. You cannot check for a class-vars state that's not even there sometimes, so we did write some fixes.
2. Now they did rewrite this part and the same happened to "positional". If i rewrite this part now, like you in part did i think, we run perhaps the next months after small new bugs from it.
3. Momentan unrpyc still works becuse the RenPy devs put the old stuff as legacy in the parameter rewrite. When they remove it later we rewrite this again.
4. The commit to this says it clearly: They are not done with redesigning the AST and ATL stuff. When they do the next part we rewrite this again... We do not know where this goes in the end.
5. I admit, some of the code in "unrpyc" i do not understand or is hard to follow where it goes and what it does. I did not write this program, so another dev's code to understand is horror and its on top of it a "Decompiler". Not the easiest things out there.
6. The "unrpyc" boss said it self: In unrpyc is a lot of old code for py2 and hacks and stuff for older RenPy compatibility etc. So if he has time again, i expect bigger changes in unrpyc. Then is this code for parameters again rewritten.
7. In May this year ends RenPys py2 support and they throw this all out. I don't want to know what this means... So, i expect the 7.7x version the last we see from py2. Maybe this means we rewrite then some stuff... again. o_O

No thanks you, a quick fix does for now IMHO. If not, its not the end of the world. I think unrpyc will anyway need to be in big parts redone. Half of the code out, some rewritten, half of the old code will still be good. A new version for py3 only and a old one for legacy RenPy is IMHO better to maintain.

BTW: Good work VepsrP.

Greets
 
Last edited:

VepsrP

Well-Known Member
Modder
Dec 13, 2017
1,387
1,430
391
No thanks you, a quick fix does for now IMHO. If not, its not the end of the world. I think unrpyc will anyway need to be in big parts redone. Half of the code out, some rewritten, half of the old code will still be good. A new version for py3 only and a old one for legacy RenPy is IMHO better to maintain.
So you just bypassed the lack of [positional, extrapos, extrakw] properties of the paraminfo object, eventually just losing the function parameters. I was able to add support for a new way of arranging function parameters. By the way, this method is completely consistent with what is used in python itself. As for legacy, it's support for old unrecompiled scripts, which is exactly what I dislike most about RenPy.

If you don't want to waste time working with "temporary" changes, I can suggest the "at transform" component (file - sl2decompiler.py , function - print_keywords_and_children, located at the very bottom. This stuff doesn't work properly in the game Our Bright Days, if I remember correctly. For this reason, I decided to rewrite all unrpyc - to change the way decompiled parts are written to the final file. A partial implementation can be viewed on my GitHub, the unrpyc-2.0 project.
 
  • Like
Reactions: yoyomistro

Madeddy

Well-Known Member
Dec 17, 2017
1,016
735
244
Do you think this bit here will fix this bug with Our Bright Days decompilation...
...another issue I ran into with that title decompiled with passing **kwargs into a list; the shopping list code passes **kwargs...
I see. I must say my forks unrpyc version is broken for renpy 7.7.x/8.2.x and probably even for 7.6.x/8.1.x. I am too far behind on fixes and I'm in over my head here ATM. Well shit.
VepsrP did good work with his version. I mean it! Must been a lot of work. :unsure:
 
  • Like
Reactions: yoyomistro

Madeddy

Well-Known Member
Dec 17, 2017
1,016
735
244
So you just bypassed the lack of properties of the paraminfo...
Yeah, i stayed simply in the old system because they change the new all the time like i said up there. This tires me.
...legacy, it's support for old unrecompiled scripts, which is exactly what I dislike most about RenPy.
I see where you're coming from. Agreed. And instead of making a clean cut, the RenPy devs ride since two years or more this dead Py2-horse with the 7.5.x - 7.7.x versions.
smh-shake-head.gif
...the "at transform" component (file - sl2decompiler.py , function - print_keywords_and_children ... This stuff doesn't work properly...
I thought so too something is not right there. This settles it. GAH!
on my GitHub, the unrpyc-2.0 project.
Huh? Cannot find this. But sounds VERY interesting!
Edit: Found it.
 
Last edited:
  • Yay, update!
Reactions: Twistty

VepsrP

Well-Known Member
Modder
Dec 13, 2017
1,387
1,430
391
I think you should edit OP, because you can run powershell scripts on GNU/Linux and MacOS too. Just need to install it and that's it. Much easier than trying to fuck around with installation python2 on some distos
I use Arch Linux btw
You are the first Linux user who does this, everyone else is asking to make a special version for their platform. Plus, I can't guarantee that everything will work on Linux or mac, so I'd rather leave it as it is.
 

Madeddy

Well-Known Member
Dec 17, 2017
1,016
735
244
Just dropping the info and some thoughts:
RenPy 8.2.x / 7.7.x is officially out two days ago.

I guess in a few weeks will the number of games on this engine version increase and with all the changes in RenPy, will be fruitless try's to decompile with incompatible unrpyc/unren versions. So i expect again some posts and cry`s about this etc. I don't know if VepsrP catched all changes in his last unrpyc embed but we will see.

If someone wants to take a look which future changes for decompiler compatiblity are lurking out there, here is a nice little link:
Have fun! :WutFace:
 
Last edited:
5.00 star(s) 3 Votes