Oh yeah I can totally see that being ridiculous. I'll try 5 for now. Reducing but generally not outright negating the amount of time spent hurt.
Even +5 is pretty good. How many times has one of your girls been injured for 5+ days?
About upkeep, (when using King's Way to quickly test my events) a level 1 S rank girl has about 450 gold/day upkeep on low pay, and that's without any traits that increase it. So, not a huge deal, but somewhat significant.
An
actual rank S girl with levels from a debug save from IDK who had ~900 upkeep per day, 254 at minimum (which is easily reachable via love and trust), and ~1560 income per day over the last month (and that was the best girl on the entire roster). Even minimising all upkeep, that's 1/6. And that doesn't account for taxes, brothel upkeep or other expenses, so it's actually more than that.
In conclusion, it's something like +10% tips at the very least. For many girls, more like ~20-50% extra tips. Looks like a pretty big deal to me. Maybe I'm overlooking something, because I have no vanilla experience to speak of.
Riven: add +20% increased upkeep
That actually puts her on the weak side, if my upkeep musings are right. I'd just lower her bonus to +5.
Tracer: add -3 defense (keeping the very strong -20% tiredness, but adding a strong downside to balance it)
Defence is actually not that powerful compared to tiredness, since girls don't get attacked all that often.
That's not really a significant downside for what will essentially be +20% tips in the long run (with Tempting Fate). Again, I suggest moving the whole thing to Ahri for the Fox theme, and making the Cumflator into something fetish-related. +3-4 fetish satisfaction, +500 fetish preference off the bat, a 'whore obedience target' boost, something along these lines.
Kindred: add +5 const, sens and libido
Mostly cosmetic and she remains among the weakest.
Yennefer: 8 sens and refinement /rank (up from 5)
Will do little to make her trait more attractive because, unlike the redhead sorceress, she needs to be highly ranked to get the benefits, which are really not all that strong in the first place.
Give her some sort of mana boost, maybe? Or something to go with the unicorn?
Ciri: Valuation removed, add +3 defense
There are a lot of these defence traits now, aren't there?
Elizabeth: +7 sens /rank (up from 5)
See Kindred.
Nidalee: max energy removed, add +8 sex /rank
Giving her a corresponding energy boost (even +10%) would have been more thematic, unique, interesting and powerful.