- Jun 5, 2021
- 687
- 2,018
Oceanlab not sure if anyone has mentioned this, I havent looked at this thread in months, but every chapter 4.5 replay referencing the BellaKiss3x5 variable is bugged.
Easy fix, find and replace BellaKiss3x5 with BellaKiss03x within every file in this path: ...\game\Benutzerdefiniert\Replay\Ch4x5
Long term fix, redevelop the replay function so it's within the normal gameplay script. You wouldn't have to synchronize changes in multiple places if you did it this way. The duplication isn't necessary and creates unnecessary tech debt. The VN Desert Stalker is a good reference for this, or you can hit up scrappy.
Unsolicited constructive criticism, there is no way you dont confuse yourself regularly with these variable names lol. Fitness and fitness, vicdate and VicDate, miladate and MilaDate. I quickly glanced through the codebase and it seems like you've changed your naming scheme in nearly every update. I would recommend coming up with a consistent self-documenting variable naming scheme so you don't trip yourself up in the future, especially as scenes get more complex with the many, many, LIs.
I think <Char Name><One Word Descript><Chapter>x<Sub-chapter> works fine, so MilaDate4x0 or MilaDate4x5 is cool. Not saying you have to adhere to that scheme, python convention is typically snake-cased (ex. mila_date_4x0), only that you need to choose something that's consistent if you plan to bring on developers who will have to make sense of all this. The inconsistency is also a form of tech debt. Personally, i'd retrofit previous chapters to adhere to that scheme as well.
Im a web developer, I don't do renpy shit, but I have fiddled with python quite a bit to make automation scripts. I think a linter like pylint should be ok to use with renpy? I'm not certain tho and this is only necessary if you feel you need something to strictly enforce adhering to that naming scheme.
That's all I got, ill go back to making myself scarce.
PS. Chapter 5 needs a succulent ass shot of the objectively superior LI, Mila. You will include this or I will riot. Thanks and god-speed brethren.
Easy fix, find and replace BellaKiss3x5 with BellaKiss03x within every file in this path: ...\game\Benutzerdefiniert\Replay\Ch4x5
Long term fix, redevelop the replay function so it's within the normal gameplay script. You wouldn't have to synchronize changes in multiple places if you did it this way. The duplication isn't necessary and creates unnecessary tech debt. The VN Desert Stalker is a good reference for this, or you can hit up scrappy.
Unsolicited constructive criticism, there is no way you dont confuse yourself regularly with these variable names lol. Fitness and fitness, vicdate and VicDate, miladate and MilaDate. I quickly glanced through the codebase and it seems like you've changed your naming scheme in nearly every update. I would recommend coming up with a consistent self-documenting variable naming scheme so you don't trip yourself up in the future, especially as scenes get more complex with the many, many, LIs.
I think <Char Name><One Word Descript><Chapter>x<Sub-chapter> works fine, so MilaDate4x0 or MilaDate4x5 is cool. Not saying you have to adhere to that scheme, python convention is typically snake-cased (ex. mila_date_4x0), only that you need to choose something that's consistent if you plan to bring on developers who will have to make sense of all this. The inconsistency is also a form of tech debt. Personally, i'd retrofit previous chapters to adhere to that scheme as well.
Im a web developer, I don't do renpy shit, but I have fiddled with python quite a bit to make automation scripts. I think a linter like pylint should be ok to use with renpy? I'm not certain tho and this is only necessary if you feel you need something to strictly enforce adhering to that naming scheme.
That's all I got, ill go back to making myself scarce.
PS. Chapter 5 needs a succulent ass shot of the objectively superior LI, Mila. You will include this or I will riot. Thanks and god-speed brethren.
