Oct 14, 2020
113
126
I seriously hope you guys change your wording - all those code changes are 'hotfixes' at most. Fixing stuff is more than just changing some code on the fly - fixing code means you actually make sure that nothing else breaks too. Far too many posts and problems are a sentiment that things are mostly just hotfixed. The code owner is basically the only one that can actually fix stuff properly since he also releases.
There is little difference between a "hotfix" and a "fix" except release timeframe - both are bug fixes. "Hotfixes" in the industry parlance are fixes for issues that basically make the game unplayable for a large number of people and cannot be delayed. Normal bug fixes would be something that can be delayed to the next version because it only hits a few people or there is an easy workaround or whatever. For example, lunch dates not working? Worthy of a hotfix. A tier 4 trait causes only part of its effects to happen? Not worthy of a hotfix, and goes in next release if at all.

The changes I point out are usually obviously side-effect free: Vren misspelling his own function names, misunderstanding .append return value, etc. Most of the fixes here are of that nature, so they should be quite safe - or, at worst, no less broken than before.
 
  • Like
Reactions: dalzomo

toolkitxx

Well-Known Member
Modder
Donor
Game Developer
May 3, 2017
1,473
1,794
There is little difference between a "hotfix" and a "fix" except release timeframe - both are bug fixes. "Hotfixes" in the industry parlance are fixes for issues that basically make the game unplayable for a large number of people and cannot be delayed. Normal bug fixes would be something that can be delayed to the next version because it only hits a few people or there is an easy workaround or whatever. For example, lunch dates not working? Worthy of a hotfix. A tier 4 trait causes only part of its effects to happen? Not worthy of a hotfix, and goes in next release if at all.

The changes I point out are usually obviously side-effect free: Vren misspelling his own function names, misunderstanding .append return value, etc. Most of the fixes here are of that nature, so they should be quite safe - or, at worst, no less broken than before.
I have been in the 'industry' for 3 decades now and that is not how serious development works. Might be done in quick and dirty game development companies but not in areas where there is serious code and you break stuff in complex systems. And the confused users in this thread are a sign that stuff gets hot-fixed without thought of further consequences than actually fixed.
 
  • Haha
Reactions: shkemba and hyfka

Thaunatas

Member
Aug 25, 2021
235
124
I have been in the 'industry' for 3 decades now and that is not how serious development works. Might be done in quick and dirty game development companies but not in areas where there is serious code and you break stuff in complex systems. And the confused users in this thread are a sign that stuff gets hot-fixed without thought of further consequences than actually fixed.
Dude, get the stick out of you a**. This is a forum for games made by (mostly) unprofessional coders, no serious business companies.
 
Oct 14, 2020
113
126
I have been in the 'industry' for 3 decades now and that is not how serious development works. Might be done in quick and dirty game development companies but not in areas where there is serious code and you break stuff in complex systems. And the confused users in this thread are a sign that stuff gets hot-fixed without thought of further consequences than actually fixed.
Not going to compare credentials, but that is how I have done and seen patches done. Simple, obvious fixes get little testing beyond "Was it broke before? Yes. Is it working after? Yes. What was the bug? Typo in method name. Great, ship it." And if they are very important, they go out faster as "hotfixes" out of the normal release cycle.
 

toolkitxx

Well-Known Member
Modder
Donor
Game Developer
May 3, 2017
1,473
1,794
You dont get the point. THIS is the game thread - not the bugfix or a mod thread. Players come here to read and talk about the game and the minority has any relation to code. Yet they get thrown bits and pieces of code thrown at them with notions of 'things being fixed' - while they are not officially. action -> consequences. A shitload of posts of confused users is simply proof of that and those 'fixes' are just floating around afterwards with no-one taking responsibilities for them.
 

dalzomo

Active Member
Aug 7, 2016
909
751
I feel like the fanbase using an imprecise term for a solo amateur dev's porn game being held to the standards of serious development in the 'industry' might be a bit overly strict, but I also don't feel like it's worth arguing over and I hate to offend so I edited my post to use different terminology. I'm certain it will catch on ^_^

I'm planning a better early walkthrough than my earlier mess, complete with step-by-step instructions on how to unlock hundreds of Clarity by Tuesday night (with more practically whenever you want it) and the thorough explanation of production I completely forgot to include. I intend to have it posted by the end of the weekend
 

Thaunatas

Member
Aug 25, 2021
235
124
You dont get the point. THIS is the game thread - not the bugfix or a mod thread. Players come here to read and talk about the game and the minority has any relation to code. Yet they get thrown bits and pieces of code thrown at them with notions of 'things being fixed' - while they are not officially. action -> consequences. A shitload of posts of confused users is simply proof of that and those 'fixes' are just floating around afterwards with no-one taking responsibilities for them.
Most of the "fixes" posted in this thread only have the intention to make the game or a broken feature playable until an official fix is released. I dont think many users of this forum actually care about what the fix is called in the end or where it comes from, as long as its working. Just my two cents...
 

dalzomo

Active Member
Aug 7, 2016
909
751
You dont get the point. THIS is the game thread - not the bugfix or a mod thread. Players come here to read and talk about the game and the minority has any relation to code. Yet they get thrown bits and pieces of code thrown at them with notions of 'things being fixed' - while they are not officially. action -> consequences. A shitload of posts of confused users is simply proof of that and those 'fixes' are just floating around afterwards with no-one taking responsibilities for them.
This is the vanilla thread, which has always been used for the discussion and support of the vanilla game in the form of instruction, advice, and amateur fan hotfixes (aka zigs) to help other players enjoy the game despite Vren's enthusiastic optimism. Many of the zigs posted here are either from the comments by fans on Patreon or are reposted there from here or PMed to Vren and have subsequently been added to the game officially by him. Even though he does not take part in the thread, this discussion and the zigs posted here further the development of the vanilla game greatly
 

Clutchfrog

Newbie
Jan 3, 2021
74
117
I dug through the code concerning emily and I think I found the cause for the problem.

In /game/game_roles/role_student.rpy Line 40:

Code:
def student_test_intro_requirement(the_person):
        if not the_person.event_triggers_dict.get("test_rewrite_intro_enabled", False):
            return False
        else:
            return True

    def student_test_requirement(the_person):
        if not the_person.event_triggers_dict.get("student_exam_rewrite_enabled", False):
            return False
        elif not university.has_person(the_person):
            return "Wait until she's on campus."
        elif day%7 == 5 or day%7 == 6:
            return "Closed on the weekend."
        elif time_of_day == 4:
            return "Too late to start the exam."
        else:
            return True

    def student_offer_job_requirement(the_person):
        if not the_person.event_triggers_dict.get("student_offer_job_enabled", False):
            return False
        elif mc.business.get_employee_count() >= mc.business.max_employee_count:
            return "At employee limit."
        else:
            return True
needs to be changed into:

Code:
def student_test_intro_requirement(the_person):
        if not the_person.event_triggers_dict.get("test_rewrite_intro_enabled", False):
            return False
        return True

    def student_test_requirement(the_person):
        if not the_person.event_triggers_dict.get("student_exam_rewrite_enabled", False):
            return False
        elif not university.has_person(the_person):
            return "Wait until she's on campus."
        elif day%7 == 5 or day%7 == 6:
            return "Closed on the weekend."
        elif time_of_day == 4:
            return "Too late to start the exam."
        return True

    def student_offer_job_requirement(the_person):
        if not the_person.event_triggers_dict.get("student_offer_job_enabled", False):
            return False
        elif mc.business.get_employee_count() >= mc.business.max_employee_count:
            return "At employee limit."
        return True
Since I dont play the vanilla version of the game, I didnt test it myself, but since these lines of codes come from the (bugfixed) modded version of 0.49.2, they should be working. Give it a try
Hey I appreciate the help. I actually figured out and had forgotten that in the modded version, You have to go to Nora and tell her Emily is ready to take the test. Long story short, I am an idiot lol.
 

ZEXX

Newbie
Aug 24, 2017
61
20
well turns out the serums i made were being auto sold ,i figured it out eventually but i am used to dealing with complicated mod stuff ,that section should have an easier to understand interface or the wording used.

another thing i have been wondering about ,how do you add serum to your inventory to use on girls not at the work place ,all the ones i have made can't seem to be added and i do have spare doses ,or can you only add the super perfect ones way later.
 
  • Like
Reactions: dalzomo

Thaunatas

Member
Aug 25, 2021
235
124
Hey I appreciate the help. I actually figured out and had forgotten that in the modded version, You have to go to Nora and tell her Emily is ready to take the test. Long story short, I am an idiot lol.
Oh, didnt realize you played the modded version, since this is the thread for the vanilla game.
 

Thaunatas

Member
Aug 25, 2021
235
124
well turns out the serums i made were being auto sold ,i figured it out eventually but i am used to dealing with complicated mod stuff ,that section should have an easier to understand interface or the wording used.

another thing i have been wondering about ,how do you add serum to your inventory to use on girls not at the work place ,all the ones i have made can't seem to be added and i do have spare doses ,or can you only add the super perfect ones way later.
Go to your production department, there you can access your production stockpile and move serums to your inventory
 

Thaunatas

Member
Aug 25, 2021
235
124
heh yeah i found it before reading the reply thanks though ,game needs to have bigger text.
Yeah, the vanilla game lacks a bit on the guiding through the basics side, and the interface has its flaws too. The modded version is much more apealling in terms of interface and readability, and also has easier to understand explanations. It might not be at the newest version of the game, but the qol upgrades and the additional contant make more than up for that
 

slowpersun

Active Member
May 30, 2017
677
449
What is in the 0.51 poll?
Basically everything but new serums... you can view the options, but need to pay dat Patreon $$ to vote. So far adding Lily/sister stuff is winning, although just shows relative bars for vote amount, no exact # of votes is publicly available.
 

coretex

Active Member
Jun 15, 2017
607
523
Not a patron, but the page did show me the poll.. the boxes to vote, and the numbers... so hey?
I think these are total vote #'s:

More business duties - Particularly late game/sexy ones and ones with novel effects.
107

Add duties events - Add new random events related to what duties a girl has assigned.
52

Duties for other characters - Expand the duties system to give you control over what Jennifer, Lily, etc. are doing.
75

Expanded content: Jennifer - More storyline/events involving Jennifer
149

Expanded content: Lily - More storyline/events involving Lily.
163

Expanded content: Gabrielle - More storyline/events involving Gabrielle.
115

Expanded content: Rebecca - More storyline/events involving Rebecca.
92

Expanded content: Stephanie/Nora - More storyline/events involving both Nora and Stephanie
103

Expanded content: Other minor characters - More storyline/events involving minor characters like Emily, Iris, etc.
63
 
3.40 star(s) 127 Votes