Would you please explain how this could probably be simplified / coded correctly? I want to know how dumb this is
Reasonable question.
Let me first explain the goal of this code.
So as a booting actions, we are filling a list of Patron names for later display (I assume). What i showed looks to be about 30 people but i think there's over 100 lines of these code. Our goal is to put a set of outside data inside our game by baking it into the game itself.
Baking outside data inside games is really dumb, and should be avoided.
Now i've said there's 100 lines of code like this. How easy is it to edit them? For instance this seems to have a first name, and last name field but only the first name is used. To remove that last name field would require me to make 100 extra changes and the program wont compiler without those changes.
It takes a lot of space.(Not specifically harmful)
If i recall correctly we have credit code, followed by logic code, followed by more credit code.
If you want want to edit 1 specific entry, you have to check over a hundred code statements(which are fragmented).
This is how you should do it.
>Get Patreon list
>>Process patreon list into standard format
>Get Substar list
>>Process Substar list into standard format
>>>Concat Patreon list and Substar list.
>>>>Dump file into game files.
>Write code to read file.
>> Use forloop to go through each subscriber in list.
>>> make local variables inside loop for value that change which are [firstname, subspecies]
>>>> call credits.add inside loop but use local firstname and subspecies.
>>>>>Profit
Boom, there's the pseudo code which replaces that above shown code.
It requires hand rolling 1 tool (which given the complexity is super quick) and maybe 10 lines of java code inside the game.
It's compact, easy to change/edit, doesn't bake outside data inside our exe, doesn't take exaggerated code space, and easy to edit the the list (a text file with standard format is easier to search than a text inside a code statement.)
This is just a sloppy solution to a simple problem. Is it a big deal? No! But if the solution i suggested was implemented, i wouldn't touch the credits code but in it's current state, this is an eye sore and slowing progress. I'm just going to delete these lines of code. Her backers being credited be damned.
EDIT
I want to know too, because I'm not a expert and really anything looks complicated when it comes to coding, but this looks extra spaghetti.
I will defender her a bit here. As you said, when you're not experienced, anything looks complicated.
This isn't complicated coding wise. It's mostly straight forward. It's the programming version of adding a line of text to notepad or excel.
There's just a lot of unneeded data which makes it look complex, and she shouldn't be writing every name down by hand. As stated by myself and someone else. Put it in a file. Load the file.