Thanks a lot I m still trying to upload the save file but my internet connection is not really good for uploades and I couldn t sed it per attatchemt.
- Nov 3, 2018
- 349
- 431
No problem, but if the problem still persists even with the new version, please send me that save. Iirc you should be able to reduce the size significantly when you compress it.
i start new game and in belly`s bathroom after beaing captured and forced to do blowjobs i got no actions.
- Nov 3, 2018
- 349
- 431
That's strange. No actions at all? Not even the shower action? I didn't touch that location in months. Should be working fine. Could you upload a save a few steps in the blowjob scene before it happens?
- Nov 3, 2018
- 349
- 431
Thanks ... found the problem. They have renamed one of the most important variables that breaks everything in the current dev build. omfg ...
- Nov 3, 2018
- 349
- 431
Yeah, changing a variable that is used everywhere is not a good idea
. I have uploaded a new version and a new glife.qsp as well. I tested your save and it works again.thx for quick answers. still got some error after i brush hair or try to exit. hear is save hear is link to save
You must be registered to see the links
Last edited:
It is called refactoring code and is standard practice for professional developmentYeah, changing a variable that is used everywhere is not a good idea
It makes the code easier for new devs to work on.
The down side is that it will break mods.
Oh and thanks for writing the mod, it is by far the best one as far as I am concerned.
I though that was the "normal" approach these days.
But what exactly did they change i try to ceep the old mods up to date so I can play them with the new versions but since the last 4 dev versions I have pretty much given up on the task since there is no real coherent patchlog for all of the changes and the changes of the variabels or places made no sense to me since they could just make a NEW one for the new stuff.
And thx a lot for your help since i switched the variables to the new loactions my savegame works fine again, sorry to bother u with a me probelm.
the ones that broke it were probably Renamed metka and metkM to loc_arg and locM_arg.
The location name changes are documented here
You must be registered to see the links
- Nov 3, 2018
- 349
- 431
Thanks for the report
, I fixed it and updated the qsp again.Professional developmentIt is called refactoring code and is standard practice for professional development
It makes the code easier for new devs to work on.
The down side is that it will break mods.
Oh and thanks for writing the mod, it is by far the best one as far as I am concerned.
... I normally would agree with you, but a new dev doesn't understand what $metka or $loc_arg is they have to ask either way. So to break every mod out there, even mods that aren't maintained anymore just so that a variable looks pretty is imho stupid. If it was an important change, but to lose content for this? Really? A few weeks ago they already changed the location names of important locations which also broke every mod. We now have stuff like the location city_bobka instead of bobka. I guess that makes it somehow easier for new devs to know what bobka is
Why not create a list with the important variables like $metka with a small explanation. You could give that to every new coder. It would be imo a better solution than this.
- Nov 3, 2018
- 349
- 431
You must be registered to see the links
you can find a list of all changed location names. The two variables they changed (that I know of, I asked in the tfgs forum, but I haven't gotten an answer) are $metka they changed it into $loc_arg and $metkaM they changed that to $locM_argThe naming conventions are a mess at the moment. There is work in this release to rationalise and document them.Thanks for the report
Professional development
A few weeks ago they already changed the location names of important locations which also broke every mod. We now have stuff like the location city_bobka instead of bobka. I guess that makes it somehow easier for new devs to know what bobka is
Why not create a list with the important variables like $metka with a small explanation. You could give that to every new coder. It would be imo a better solution than this.
All locations should be prefixed with the region they belong to, to make them easier to find.
It will not need to be done regularly and makes sense to do as many as possible in one release, to reduce the work for mods.
The rational behind changing metka was because multiple people asked at the same time what they were.
There were three sets of linked variables $loc / $metka, $locM / $metkaM and $menu / $menu_arg. All are the location and the $ARG[0] associated with a gt/gs call.
As we already had $menu_arg we went with $loc / $loc_arg, $locM / $locM_arg and $menu / $menu_arg.
I know it is a pain for existing mods, but it does make it easier for new devs and modders.
- Jul 26, 2017
- 12
- 14
- Aug 16, 2017
- 27
- 20
