anne O'nymous

I'm not grumpy, I'm just coded that way.
Modder
Respected User
Donor
Jun 10, 2017
10,151
14,835
Why not just save at every question?
Because it's useless, especially since for this game the most important bug happen at load time and, unless you manually verify the variables, you have absolutely no way to know if your play is now corrupted or not. At least until the moment you're rejected by the alternate ending of the update. And still you don't necessarily understand that you have been rejected, since you don't know what to expect from this said alternate ending.
 

psychodelusional

Member
Donor
Game Developer
Dec 8, 2017
210
780
So I'll never see it unless I, again, restart from scratch a game I already started one hour ago... greet !
Choosing to cut MC's dick end the game (which is logical) while hesitating led to a reset of everything. Obviously not for everyone, but if it happened to me, it happened to other players... The points lose can be corrected, but the fact that _actions is defined with the sole reset's trigger make the game completely unplayable.

Seriously, why using a so complex mechanism, which lead to bugs half of the time, when anyway 99,99% of the time (I let you the benefit of doubt) a direct manipulation (with the help of __setattr__ if you really want to keep your dynamical approach) would do exactly the same thing, but without the bugs ?
And why this useless after_load process since the Machine objects are saved ? You just create bugs by doing this. Depending of the place you save, you've a correct load or encounter a list index out of range because there's more Machine objects in temp_machines than returned by your get_instances, first boom. And like on top of this you assume that the order will be the same in temp_machine and in the generator returned by get_instances, second boom.
Cherry on the cake, you defined get_instances as class method while using it as a static method, and should have defined it as standalone function:
Code:
def get_instance( cls ):
    for inst_ref in cls.__refs__[cls]:
        inst = inst_ref()
        if inst is not None:
            yield inst
[...]
    python:
        for m in get_instances(M_mc.__class__):
            machines.append(m)
And why designing it as a generator when you only use it in loops which will create a list ? Directly create the list and return it. Or, better, create a dict (str as key, "reference" as value) which will let you ensure that you'll address the right object in your after_load process (if really you need it, which I still doubt about) and prevent the list index error :
Code:
        for m in temp_machines:
            if not str(m) in machines.keys(): continue
            mach = machines[str(m)]
            for state in mach._states:
                [...]
I didn't make the remake in renpy so i don't know what to tell you about the complexity of it but as far as the variables not saving, I actually fixed that within a few days but it never got upped to f95, that's why I left the "do not use old saves" text file in there in case f95 users try to use a corrupt save. So far as I know, the new saves work and will work so long as I don't change the fsm.
 
  • Like
Reactions: Carcalla

anne O'nymous

I'm not grumpy, I'm just coded that way.
Modder
Respected User
Donor
Jun 10, 2017
10,151
14,835
but as far as the variables not saving, I actually fixed that within a few days but it never got upped to f95,
What variables not saved ? I explicitly said that everything is saved and correctly saved. It's the useless process at load time which mess with the variables, nothing else.

So far as I know, the new saves work and will work so long as I don't change the fsm.
Well, I'll see a last time with the next update, because, "restart from scratch a game I already started one hour ago...", mean that it happened with a save made less than one hour before. This said, I don't have high hope for the said next update.
 

psychodelusional

Member
Donor
Game Developer
Dec 8, 2017
210
780
What variables not saved ? I explicitly said that everything is saved and correctly saved. It's the useless process at load time which mess with the variables, nothing else.



Well, I'll see a last time with the next update, because, "restart from scratch a game I already started one hour ago...", mean that it happened with a save made less than one hour before. This said, I don't have high hope for the said next update.
k
 
  • Like
Reactions: fun_bot

yoyomistro

Engaged Member
Jan 15, 2017
2,679
3,342
Because it's useless, especially since for this game the most important bug happen at load time and, unless you manually verify the variables, you have absolutely no way to know if your play is now corrupted or not. At least until the moment you're rejected by the alternate ending of the update. And still you don't necessarily understand that you have been rejected, since you don't know what to expect from this said alternate ending.
OK. I haven't taken the time to look at the code for this game closely TBH, and I usually play the updates in one sitting so I don't encounter some of the issues people seem to run into on the basis of leaving and coming back to the game. Plus I use rollback a lot too, so my experience doesn't match what most people seem to do.
 

Ignatz

What's the airspeed velocity of an unladen swallow
Donor
Feb 17, 2018
3,574
10,093
How come there is a trash can in picture 2 and not picture 1?
Why is the washing machine not next to the dryer?
Don't most dryer doors open left-to-right and not right-to-left as in the picture?
How come there is a shadow in the second picture and not the first?
Why does the shadow look like there is a light on the floor?

Oh, yeah, the lady is pretty sexy, too.
 

xןʞ

I trolled so N7 could soar.
Staff member
Moderator
Donor
Jul 19, 2017
3,052
28,030
That is actually the father.

Just so you know.
 

Ignatz

What's the airspeed velocity of an unladen swallow
Donor
Feb 17, 2018
3,574
10,093
IN the dryer? Was he cut up into pieces or folded up into a ball?
Or, are you saying he's in the trash can?
Or, is HE the trash can? Is that a metaphor?
 

Ignatz

What's the airspeed velocity of an unladen swallow
Donor
Feb 17, 2018
3,574
10,093
Wait a minute. Now I'm totally confused. Is that a dryer or a washing machine. Is apocalyps suggesting there is a separate washing machine in the room that is not right next to the dryer? Who does that?

Personally, I now think we need an entire update simply on household appliances and whether they are gender specific.
 
U

User_32285

Guest
Guest
Wait a minute. Now I'm totally confused. Is that a dryer or a washing machine. Is apocalyps suggesting there is a separate washing machine in the room that is not right next to the dryer? Who does that?

Personally, I now think we need an entire update simply on household appliances and whether they are gender specific.
Also this need s a new tag imo, <houshold appliances fetish>
 
  • Haha
Reactions: 9inchz

Ignatz

What's the airspeed velocity of an unladen swallow
Donor
Feb 17, 2018
3,574
10,093
The time is right, it appears, for an appliance conspiracy blog site.
 
3.50 star(s) 117 Votes