Dukez

Member
Dec 19, 2020
443
1,558
As someone who's been right up in the guts of this thing, is fixing it easy enough, or would a ground up remake be more efficient?
Do you have any idea what exactly could be causing problems on the devs end? Or was seeing the insides just proof that they're just sitting on their arse?
Either way, good work and thanks for all this.
In it's current state being what's in D22-23, it's easy enough since a lot of the background stuff is done and just needs converting previous data over although most of it was already done too, the calendar data was the biggest outlier to me.

The way the calendar is built now is WAY better than it was (not talking about how progress is saved) before (Although it has bugs, if they read my code maybe they will see where I point something out :sneaky:) and is why I think the replay & gallery system should be remade. I never really considered before at how the music UI is handled but that might actually be a fit-in-replacement for these systems with a little modification.

What do I think is causing them problems? Assuming it's not a scam, then I would put it down to two things - Scope & Willpower.

Scope - We've seen some images Bluecat has posted before in discord showing him working on stuff, I think it was a D4 script and it showed some modification to how things are handled, which in this case was patch related IIRC and streamlining how it worked that would make a shorter script but have the same substance. This is purely wasted effort that won't have a perceived difference to the end user or himself - you should only be going back to these to fix how things are saved (as I did) to make them compatible with the new approach.

The character profile system is another example of this. The old code worked fine but they broke it at some point but it didn't need redoing like it has been in D22-23. I might've mentioned this in a previous post before I released it, but at first the D22-23 character profile system didn't work for me either even after enabling it, so I initially just reverted back to the previous system in and looked at how it worked in Week 1 fixed it, so it displayed & saved things correctly. Only after I ran into issues later unrelated to this and having fixed the old system, I revisited the newer one and decided to put that back in since the fix applied to this system as well. There's a lot of dead code in the new system, almost like they were trying to work out why stuff wasn't saving...... (FYI for them... defaulting != defined in trying to save something).

Willpower would be the main cause though I'd bet. Putting wasted time on things that don't matter aside, you just need the will to work on something and see it through which Bluecat clearly had in the beginning and has now lost. Sure coding is different to creating images, but both required the willpower to see it through + someone else is supposed to be helping on the coding side anyway last I saw.

Oh, also it's easier to fix something than it is to restart from scratch but it does have it's downsides in that you don't know exactly how everything comes together when it's not your code so it can slow you down at times. Starting from scratch would be a good excuse to delete it's UI though (I really do not like it, it's so wasteful in space).

I literally just realized this now, despite myself writing some commented out lines on certain things while I was doing this but this actually had no code documentation in it at all. Who TF coded this again? I'm actually pissed now since I've realized this because this is standard code practice LOL. They might not of broken their own features if they had documented it, who knows.

Damn wall of text again too. GG
 

Burgh917

Active Member
Dec 20, 2019
567
829
Was wondering if the Darkmind patch will work with this?

Nvm: It won't...

Edit: Thank you Dukez for pointing out my idiocy :ROFLMAO: :ROFLMAO:
I got so excited i didn't read far enough and thought the second download was for Mac. Appreciate the extra effort. :love:
 
Last edited:
  • Sad
Reactions: Soulpuppet

Dukez

Member
Dec 19, 2020
443
1,558
Was wondering if the Darkmind patch will work with this?

Nvm: It won't...
If your talking my merge, then the darkmind patch I made will work with it which is linked in the same link. It's two separate downloads.

I did but my post was deleted because his Discord mods don't allow stuff from F95.
So if I was to pop into his discord and post it myself as the author...? Well it'd still get deleted I'm sure. I wouldn't even bother trying though :KEK:
 
  • Like
Reactions: Burgh917

Ickerax

Member
Feb 14, 2020
264
669
Dukez Great work on the merge, I have played the first few days so far. I cant wait to see how you handled the phone change format in the last version. If you have time to tweak the merge would you add the improvements Lain made or week 1? otherwise you lose a lot of content.
 

Dukez

Member
Dec 19, 2020
443
1,558
Dukez Great work on the merge, I have played the first few days so far. I cant wait to see how you handled the phone change format in the last version. If you have time to tweak the merge would you add the improvements Lain made or week 1? otherwise you lose a lot of content.
Improvements like what? Only thing that comes to mind is where you can see both path choices, which only ever happens like a couple times in week 1? I think it's not worth my time. Just make a save when you get there and explore it after because I don't think your choices really matter much past week 1, it becomes basically a linear game for the most part.

If your referring to something else you'll have to enlighten me.
 

Ickerax

Member
Feb 14, 2020
264
669
Improvements like what? Only thing that comes to mind is where you can see both path choices, which only ever happens like a couple times in week 1? I think it's not worth my time. Just make a save when you get there and explore it after because I don't think your choices really matter much past week 1, it becomes basically a linear game for the most part.

If your referring to something else you'll have to enlighten me.
Yes it got linear is week 2 but first week you often missed scenes. below is from lains mod ..

You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.
https://f95zone.to/threads/ecchi-sensei-lains-improvements-scene-gallery-mod-week-1.25300/

And again it was only done for week 1 as week 2 onwards it just changed to a do or dont do rather than pick 1 only selection.
I have no idea why it creates 2 spoilers, i removed the extra formatting but still insisnts on 2 entries, wierd. I blame vegan's.
 
Last edited:

Dukez

Member
Dec 19, 2020
443
1,558
Yes it got linear is week 2 but first week you often missed scenes. below is from lains mod ..

You don't have permission to view the spoiler content. Log in or register now.
You don't have permission to view the spoiler content. Log in or register now.
https://f95zone.to/threads/ecchi-sensei-lains-improvements-scene-gallery-mod-week-1.25300/

And again it was only done for week 1 as week 2 onwards it just changed to a do or dont do rather than pick 1 only selection.
I have no idea why it creates 2 spoilers, i removed the extra formatting but still insisnts on 2 entries, wierd. I blame vegan's.
I was going to say no since I think it's more than fine to just use saves since it's not much of a recurring theme through the game, but the mao dance thing got me wanting to check and it's not actually in the script to be shown so I'll look into that mod tomorrow to see what other things they do if it stands out, and make a small patch for it.
 
  • Like
Reactions: Ickerax

txhp23

New Member
Jan 20, 2021
12
15
I was going to say no since I think it's more than fine to just use saves since it's not much of a recurring theme through the game, but the mao dance thing got me wanting to check and it's not actually in the script to be shown so I'll look into that mod tomorrow to see what other things they do if it stands out, and make a small patch for it.
Have you ever contacted Blue about coding for the project? You did all this for free when you could have gotten paid for it!
 
  • Thinking Face
Reactions: Jeancul

JohnF95zone

Engaged Member
Oct 31, 2017
2,016
3,520
Have you ever contacted Blue about coding for the project? You did all this for free when you could have gotten paid for it!
He is secretly Batman aka Bruce Wayne, otherwise he would have followed the Joker's way, "If you're good at something, never do it for free!" and also he is a billionaire, he does stuffs for free all the time.

Btw, don't tell anyone about this, keep it a secret. But then, if you're good at keeping secret, you're expecting to get paid!

Crap! I don't have money because I don't get paid for being bad at keeping secret in the first place:ROFLMAO::p.
 

Dukez

Member
Dec 19, 2020
443
1,558
Have you ever contacted Blue about coding for the project? You did all this for free when you could have gotten paid for it!
Never bothered, I think I've offered here that he could reach out if he wanted to previously (Although he hates this place apparently, despite still coming here) so either he or his free worker Skummy could've reached out, but I'm not particularly interested in it anyway so I would need convincing at the very least. Games dead though, so does it really matter?

Well here's your partially fixed Lain mod + Also added in Shawn's mod (D8-14) since adds some additional route choices while playing. I say partial because while the choices and that should work fine I haven't tested them all and if it breaks the save later on then that's just too bad lol. Also I fixed the gallery (only has content in days 1-7) to "work" it is not 1:1 to my script meaning things like the animation control speed bar won't appear in any animations that support them while accessing them from this gallery. Other things like mao's dance (which was a vote recap animation in the end, meh) in the gallery will end up erroring too although I imagine this is an outlier and most will work.

 
Last edited:

Mahony

Member
Jun 2, 2017
110
272
Few weeks I guess, If I was to hazard a guess over those weeks I maybe put in like 40 or so hours total? A fair portion of it was me troubleshooting various things, like I started off on renpy 8.0.3 for a while before I moved down to an older version. Some of the things I wanted to do was get rid of the "Day 1" etc pages or when you go past page 9 the pages list would up to to 10-19 and so on but I couldn't get it working properly lol.

After that I thought "maybe I'll just change the save name to be the current day your on?" but I ran into the problem that it would use the variable that gets that info, so when you loaded a different save all the other save names would update to that... tried various ways at tackling it to no avail so I reverted it.

My least fun part was translating the calendar stuff, since the new system was VERY different to the old one and included a lot of new entries that weren't translated so I essentially ended up just having to go line by line creating my own translations (they are deep learning ones for those curious, more than fine for this stuff though) but this ultimately led me down the path of checking what else might be missing, hence some character profiles and such being added.

I was strongly considering filling out the replay system to include stuff from days 8-23... but when I looked at how the code for it was it just seemed tedious and I'd rather try to remake that instead which I didn't want to do. So Bluecat can do that.

Bouncing off that discord post above, one thing that is VERY clear to me having to skip through a few times from start to finish is that each day between 1 & 7 is A LOT longer than any day made after those first 7. I don't think this is a bad thing but it really stood out to me because even while skipping through so I could make sure the game works properly start to finish, It would take me like 20-25~ mins just to get to day 8, whereas days 8-23 is probably like 30~ mins or so. I only had to do this a couple times but I hated it xD.
To be fair mate 40 hours of work in 3 years is way too much when you could earn the same money doing 0 hours of work
 

Ickerax

Member
Feb 14, 2020
264
669
(Using Dukez full version with the new patch )I get an error on day 23 when everyone in the pool, Just before who you select who to err go and talk to :)
```
I'm sorry, but an uncaught exception occurred.

While running game code:
File "game/menu/screens.rpy", line 211, in menu
File "game/menu/screens.rpy", line 215, in execute
File "game/menu/screens.rpy", line 215, in execute
File "game/menu/screens.rpy", line 217, in execute
File "game/menu/screens.rpy", line 218, in execute
File "game/menu/screens.rpy", line 219, in execute
File "game/menu/screens.rpy", line 220, in execute
File "game/menu/screens.rpy", line 221, in execute
AttributeError: 'unicode' object has no attribute 'd2'

-- Full Traceback ------------------------------------------------------------

Full traceback:
File "Days/D22+23.rpyc", line 4099, in script
File "renpy/ast.py", line 1903, in execute
choice = renpy.exports.menu(choices, self.set, args, kwargs, item_arguments)
File "renpy/exports.py", line 1010, in menu
rv = renpy.store.menu(new_items)
File "game/menu/screens.rpy", line 211, in menu
File "renpy/exports.py", line 1250, in display_menu
rv = renpy.ui.interact(mouse='menu', type=type, roll_forward=roll_forward)
File "renpy/ui.py", line 299, in interact
rv = renpy.game.interface.interact(roll_forward=roll_forward, **kwargs)
File "renpy/display/core.py", line 3377, in interact
repeat, rv = self.interact_core(preloads=preloads, trans_pause=trans_pause, pause=pause, pause_start=pause_start, pause_modal=pause_modal, **kwargs) # type: ignore
File "renpy/display/core.py", line 3810, in interact_core
root_widget.visit_all(lambda i : i.per_interact())
File "renpy/display/core.py", line 582, in visit_all
d.visit_all(callback, seen)
File "renpy/display/core.py", line 582, in visit_all
d.visit_all(callback, seen)
File "renpy/display/core.py", line 582, in visit_all
d.visit_all(callback, seen)
File "renpy/display/core.py", line 582, in visit_all
d.visit_all(callback, seen)
File "renpy/display/core.py", line 582, in visit_all
d.visit_all(callback, seen)
File "renpy/display/screen.py", line 451, in visit_all
callback(self)
File "renpy/display/core.py", line 3810, in <lambda>
root_widget.visit_all(lambda i : i.per_interact())
File "renpy/display/screen.py", line 462, in per_interact
self.update()
File "renpy/display/screen.py", line 653, in update
self.screen.function(**self.scope)
File "game/menu/screens.rpy", line 215, in execute
File "game/menu/screens.rpy", line 215, in execute
File "game/menu/screens.rpy", line 217, in execute
File "game/menu/screens.rpy", line 218, in execute
File "game/menu/screens.rpy", line 219, in execute
File "game/menu/screens.rpy", line 220, in execute
File "game/menu/screens.rpy", line 221, in execute
File "renpy/ui.py", line 992, in _textbutton
text = renpy.text.text.Text(label, style=text_style, substitute=substitute, scope=scope, **text_kwargs)
File "renpy/text/text.py", line 1594, in __init__
self.set_text(text, scope, substitute)
File "renpy/text/text.py", line 1712, in set_text
i, did_sub = renpy.substitutions.substitute(i, scope, substitute)
File "renpy/substitutions.py", line 278, in substitute
s = formatter.vformat(s, (), kwargs) # type: ignore
File "/home/tom/ab/renpy-build/tmp/install.linux-x86_64/lib/python2.7/string.py", line 563, in vformat
File "/home/tom/ab/renpy-build/tmp/install.linux-x86_64/lib/python2.7/string.py", line 585, in _vformat
File "renpy/substitutions.py", line 168, in get_field
obj, arg_used = super(Formatter, self).get_field(field_name, args, kwargs)
File "/home/tom/ab/renpy-build/tmp/install.linux-x86_64/lib/python2.7/string.py", line 652, in get_field
AttributeError: 'unicode' object has no attribute 'd2'

Windows-10-10.0.19041 AMD64
Ren'Py 7.5.3.22090809
Ecchi Sensei FanMerge D1+23 v1.0 DM
Sun Apr 23 19:29:14 2023
```
I remember Bluecat had the same error when day 21-23 was released, not sure what version of that you used for the merge. something to do with Saki being D2 if i remember
 
  • Haha
Reactions: Jeancul

Ickerax

Member
Feb 14, 2020
264
669
I also found lots of little bugs here and there but thats to be expected with such a large merge. Not sure if you have spoken to Bluecat yet (I found him reasonable when i have spoken to him) to see if he wants you to formally work on this. If so I will do my usual bug reporting.

I love the work on the Charactor cards btw with the extra people added. :)
 

Dukez

Member
Dec 19, 2020
443
1,558
The weird renpy bug that randomly appears strikes again ... well, one of two of them. Merge this with your game and it should fix it and eliminate this particular one from ever happening again across the game. This stems from Bluecat or his coder trying to be "smart" and making a system to automatically work out adding " 's " but it wasn't, and instead was rather inefficient considering it would require 7 characters versus just typing it, which takes 2 - not even a program's autocomplete is less than that. Pointless system.



Also I don't plan to reach out to Bluecat & I'm glad you like the character cards. I remember it being debated a while back if it should even be a thing haha.
 
4.10 star(s) 146 Votes