Yeah, I might adopt a policy of not fixing issues with the original interface TL. I should've been more attentive or made it from scratch. At least there are no large issues but there are specific action bugs that must've existed for so long now.
This issue is only with the lizardman negotiation. Specifically because he checks for an item in negotiation "Viking Helm" and in the interface TL there's a space in the object name during that script check, which breaks it.
I've fixed it and uploaded the fix to the translation patch mega folder. Not even updating the version number for this one. Heads up again for any readers that I don't have access to the pre-patched main download, so you'll have to download the updated TL and reapply it. Shouldn't break any saves tho.
Also to be fair, I'm guessing not many people ever tried to recruit the one lizardman until today.
Yeah your translation unleashed the masses.
GIT and version control were unknown to me at this point.
I learned how the code approximately worked as i made my way through the files.
I only used Notepad++ and its "Search in all files" & "Replace in all files", the rest was praying.
I remember that i started to use the underscore exclusively after some point for word translations, otherwise i would miss a word somewhere.
The problem came to find all already translated instances again.
Found out why i translated viking helm without underscore:
i translated item.tsv; there are 31 items and only Viking Helm (place 26) is used as a variable. i guess after 20 non var hits i assumed items do not get used as variables, only as plain text, and therefore dont need an underscore
The other big hurdle was the color coding.
This was literally pain.
Isolate all relevant single latin letters in a source code. GG
All stringbuilders were translated and rearranged by hand, so that there where some duplicate symbols in some strings is not suprising. If you select with mouse and then Strg+X / Strg+C -> Strg+V (times 200), it is bound to mess something up.
I just threw the original japanese files in git and applied my old patch on top of it.
And started scrolling through the files.
Here are some lines which most likely should error:
(If you already fixed them, even better)
(first line original japanese with color code swapped; second line is the patch)
quest.ks
Code:
@notice text=&'"ζ" + game.curExplorer.name + "θがαε僧侶兵θ を雇えるようになりました!"'
@notice text=&'"ζ" + game.curExplorer.name + "αθcan now hireαεPriest θ!""'
battle.ks
Code:
[emb exp='game.active.name']隊は
[emb exp='game.active.name']'s squad
[r][emb exp='game.defObj.name']の[emb exp='tf.temp']
[r][emb exp='game.defObj.name']'s [emb exp='tf.temp']
Does " 's " for genitiv even work at all ?
It seems " ' " is used as indicator for the parser to find expressions.
There are quiet a few more of this in this file.
Thanks @
Ruyne,
i have an absolute blast scrolling through my old code, and reviewing it now from the perspective of an actual experienced software developer.
(And actually understanding what the code as a whole does)