- Jun 10, 2017
- 10,369
- 15,286
Well, glad if i could be of some help.
I'll even continue, this time knowingly:
The line 15 and 16 of your mod have an indentation problem. As it is, they will be seen as part of the
if block, and so never be proceeded, since it come right after a return. Just put the lines one level of indentation left, and it will be good :
Code:
if renpy.get_filename_line()[0].startswith( 'renpy' ):
return( lName, abnormal )
MaxModLS.update( { str( renpy.call_stack_depth() ): lName } )
return( lName, abnormal )currentLabel actually, it don't prevent the mod to works correctly.Also, your
MaxMod code is correct, but you would gain in changing the order of the conditions.Actually you test the text, then the file, what imply that the further the player will be in the game, the higher will be the number of tests that failed before you catch the right one. By example, all the test regarding "day1.rpy" will be proceeded before the line for "day2.rpy" (assuming it's where the player is at this moment) will be proceeded.
If you invert them, you'll limit both the number of test, and the number of lines you've to write :
Code:
if file.endswith( "day1.rpy" ):
if text == "No, I want to play the full game":
return "[gr]No, I want to play the full game"
if text == "Yes, I want to play the censored version":
return "[rd]Yes, I want to play the censored version"
[the other tests for /day1/]
elif file.endswith( "day2.rpy" ):
if text == "\"I found an ancient relic.\"":
return "[gr]\"I found an ancient relic.\""
if text == "\"I found something. What do I get in return?\"":
return "[gr]\"I found something. What do I get in return?\""
[the other tests for /day2/]
elif file.endswith( "day3.rpy" ):
if text == "Continue the introduction privately.":
return "[gr]Continue the introduction privately. [sx]"
if text == "Kill them":
return "[gr]Kill them"
[And so on]It also make it that you don't have to test the file for each single test that pass (so less line to write for you), and it make it more clear where the "day2.rpy" part is, what will make it easy for you to correct an eventual error.
I don't know the game (shame on me) so I can't talk on the accuracy of the mod itself. But the mod structure is correct and effectively have no reason to alter the save files or the game structure. Therefore it can works with other mods and will not lead to save incompatibilities.
